-
Notifications
You must be signed in to change notification settings - Fork 778
[SER] HitObject accessors DXIL opcodes and check-pass tests #7276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
EDIT: Removed 4x3 opcodes from patch and rebased. This is ready for review. |
98c3926
to
132f46e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
tools/clang/test/HLSLFileCheck/validation/ser_hitobject_accessors_passing.ll
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #7310
DXC SER implementation tracker: #7214