Skip to content

[SER] HitObject accessors DXIL opcodes and check-pass tests #7276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 13, 2025

Conversation

simoll
Copy link
Contributor

@simoll simoll commented Mar 31, 2025

Closes #7310
DXC SER implementation tracker: #7214

@simoll simoll requested a review from a team as a code owner March 31, 2025 07:47
@simoll simoll mentioned this pull request Mar 31, 2025
41 tasks
@damyanp damyanp added this to the Next Release milestone Mar 31, 2025
@simoll
Copy link
Contributor Author

simoll commented Apr 4, 2025

The 4x3 opcode variants were removed from the spec (microsoft/hlsl-specs#475). WIll update this PR. Tracking this under #7310.

EDIT: Removed 4x3 opcodes from patch and rebased. This is ready for review.

@simoll simoll force-pushed the ser_dxilaccessors_patch branch from 98c3926 to 132f46e Compare April 4, 2025 12:47
Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simoll simoll requested a review from tex3d April 11, 2025 13:24
Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tex3d tex3d merged commit 94f9275 into microsoft:main Apr 13, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Apr 13, 2025
@simoll simoll deleted the ser_dxilaccessors_patch branch April 14, 2025 05:55
@damyanp damyanp moved this to Closed in HLSL Support Apr 25, 2025
@damyanp damyanp removed this from HLSL Support Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[SER] Remove 4x3 DXIL opcode variants
4 participants