-
Notifications
You must be signed in to change notification settings - Fork 778
Update DXC's CONTRIBUTING file #7265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DXC's CONTRIBUTING file #7265
Conversation
This change seeks to address some recent questions about how the LLLVM Coding Standards are applied in DXC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a link to the LLVM coding standards from here as well?
There was a broken link in the docs a few lines above (DXC has always referred to the LLVM Coding Standards in its CONTRIBUTING file). I fixed that link. Do you think it warrants a second link, or is the one in the first sentence of the containing section sufficient? |
Co-authored-by: Ashley Coleman <ascoleman@microsoft.com>
Oh, I missed that - I was looking for a link to https://llvm.org/... so didn't spot the link to a local file. If the contents of the linked file is correct then I don't think we need another one. |
I think they're correct enough. While the LLVM coding standards have evolved over the ~10 years since DXC forked, the core of the standards have remained largely the same. If we encounter issues where the DXC document is inappropriately stale I'd suggest we update it. |
This change seeks to address some recent questions about how the LLLVM Coding Standards are applied in DXC.