[NFC] containsLongVector -> ContainsLongVector #7255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I provided feedback during code review that this function should be named following LLVM conventions. That feedback did not account for the fact that SemaHLSL is otherwise consistent using CamelCase instead of camelCase naming. This corrects my error by renaming to match the consistent style in SemaHLSL.h. I've also updated the parameter naming in the source file to conform to LLVM style since I was in the area anyways.
Did I miss something? I don't see this part of the change. |
tex3d
previously approved these changes
Mar 26, 2025
Ooops. Didn't push that bit. It's there now. |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
bogner
previously approved these changes
Mar 26, 2025
tools/clang/lib/Sema/SemaHLSL.cpp
Outdated
| while (const ArrayType *Arr = qt->getAsArrayTypeUnsafe()) | ||
| qt = Arr->getElementType(); | ||
| while (const ArrayType *Arr = QT->getAsArrayTypeUnsafe()) | ||
| QT = Arr->getElementType(); |
There was a problem hiding this comment.
Looks like an accidental reformat mistake here.
damyanp
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I provided feedback during code review that this function should be named following LLVM conventions. That feedback did not account for the fact that SemaHLSL is otherwise consistent using CamelCase instead of camelCase naming.
This corrects my error by renaming to match the consistent style in SemaHLSL.h.
I've also updated the parameter naming in the source file to conform to LLVM style since I was in the area anyways.