[OMM] Implement front end diagnostics for OMM, including on TraceRayInline, and add Availability Attributes #7156

bob80905 · 2025-02-24T21:52:08Z

This PR addresses the front end part of OMM, defining the new flags defined in the spec, and implementing the relevant diagnostics should the flags be incompatible. It also adds the second template argument to the RayQuery object, which is set to have a default value of 0 if no explicit template argument is provided.
Fixes #7145

github-actions · 2025-02-26T19:04:27Z

✅ With the latest revision this PR passed the C/C++ code formatter.

damyanp

Couple of questions, but otherwise looks good to my untrained eye.

tools/clang/lib/Sema/SemaHLSL.cpp

tools/clang/lib/Sema/SemaHLSLDiagnoseTU.cpp

damyanp

Looking good - a few style nits and I think I spotted a few places where there's some unwanted copies happening.

tools/clang/lib/Sema/SemaHLSL.cpp

…iler into OMM01

tex3d

Partial review, see comments so far.

lib/DxcSupport/FileIOHelper.cpp

tools/clang/include/clang/Basic/DiagnosticSemaKinds.td

tools/clang/lib/Sema/SemaHLSLDiagnoseTU.cpp

…d declrefexpr

tools/clang/lib/Sema/SemaHLSLDiagnoseTU.cpp

damyanp

Approved, assuming the test failures are fixed and Tex is happy you've addressed his feedback.

tools/clang/lib/AST/ASTContextHLSL.cpp

tools/clang/lib/Sema/SemaHLSLDiagnoseTU.cpp

tools/clang/test/SemaHLSL/rayquery-decls-errors-TU-multiple.hlsl

tools/clang/test/SemaHLSL/rayquery-decls-errors-TU-export.hlsl

tools/clang/test/SemaHLSL/rayquery-trace-ray-inline-errors.hlsl

tools/clang/test/SemaHLSL/rayquery-decls-errors-TU-multiple.hlsl

tools/clang/include/clang/Basic/DiagnosticSemaKinds.td

tools/clang/test/SemaHLSL/rayquery-omm-type-diag.hlsl

tools/clang/lib/Sema/SemaHLSLDiagnoseTU.cpp

bob80905 requested a review from a team as a code owner February 24, 2025 21:52

bob80905 requested review from tex3d and removed request for a team February 24, 2025 21:52

bob80905 force-pushed the OMM01 branch from 2112a74 to 087ee90 Compare February 26, 2025 19:57

bob80905 added 4 commits February 26, 2025 13:30

draft

6728f10

add diagnostics

f34857a

finish tests, implement tracerayinline check

be104ce

remove unused vars

2b12ea4

bob80905 force-pushed the OMM01 branch from 087ee90 to 2b12ea4 Compare February 26, 2025 21:40

bob80905 and others added 2 commits February 26, 2025 13:41

Merge branch 'main' into OMM01

918fef1

chore: autopublish 2025-02-26T21:52:47Z

48b8420

damyanp reviewed Feb 27, 2025

View reviewed changes

tools/clang/lib/Sema/SemaHLSL.cpp Outdated Show resolved Hide resolved

tools/clang/lib/Sema/SemaHLSLDiagnoseTU.cpp Outdated Show resolved Hide resolved

refactor to reduce indentation

f24d511

damyanp reviewed Feb 28, 2025

View reviewed changes

bob80905 and others added 7 commits February 28, 2025 10:41

address Damyan, do some refactoring

6c6a306

chore: autopublish 2025-02-28T18:47:22Z

632169a

fix nullptr being passed

eecca92

Merge branch 'main' into OMM01

e620046

remove string comparison

6f11089

Merge branch 'OMM01' of https://github.com/bob80905/DirectXShaderComp…

0c06197

…iler into OMM01

fix refactor, fix typo

3d32cb8

tex3d reviewed Mar 4, 2025

View reviewed changes

bob80905 added 4 commits March 5, 2025 17:18

address all but 2 of tex's comments, need avail attr detection + avoi…

22054e5

…d declrefexpr

use avail attrs

82f377d

use getimplicitobjectargument()

1ed850d

self review

ccd51b9

damyanp reviewed Mar 7, 2025

View reviewed changes

tools/clang/lib/Sema/SemaHLSLDiagnoseTU.cpp Outdated Show resolved Hide resolved

damyanp approved these changes Mar 7, 2025

View reviewed changes

damyanp added this to HLSL Support Mar 8, 2025

tex3d reviewed Mar 14, 2025

View reviewed changes

tools/clang/lib/AST/ASTContextHLSL.cpp Outdated Show resolved Hide resolved

tex3d reviewed Mar 14, 2025

View reviewed changes

tools/clang/lib/Sema/SemaHLSLDiagnoseTU.cpp Outdated Show resolved Hide resolved

tex3d reviewed Mar 14, 2025

View reviewed changes

tools/clang/lib/Sema/SemaHLSLDiagnoseTU.cpp Outdated Show resolved Hide resolved

tex3d reviewed Mar 14, 2025

View reviewed changes

tools/clang/lib/Sema/SemaHLSLDiagnoseTU.cpp Outdated Show resolved Hide resolved

tex3d reviewed Mar 14, 2025

View reviewed changes

tools/clang/lib/Sema/SemaHLSLDiagnoseTU.cpp Outdated Show resolved Hide resolved

tex3d reviewed Mar 14, 2025

View reviewed changes

tools/clang/lib/Sema/SemaHLSLDiagnoseTU.cpp Outdated Show resolved Hide resolved

address Tex

09dda32

bob80905 force-pushed the OMM01 branch from ffe8d9f to 09dda32 Compare March 14, 2025 00:45

merge verifier tests across shader models

53fa9f6

tex3d reviewed Mar 14, 2025

View reviewed changes

bob80905 and others added 2 commits March 13, 2025 18:02

address Tex

a2e9f08

chore: autopublish 2025-03-14T01:04:34Z

bb5d857

tex3d reviewed Mar 14, 2025

View reviewed changes

tools/clang/test/SemaHLSL/rayquery-trace-ray-inline-errors.hlsl Outdated Show resolved Hide resolved

tex3d reviewed Mar 14, 2025

View reviewed changes

tools/clang/test/SemaHLSL/rayquery-decls-errors-TU-multiple.hlsl Outdated Show resolved Hide resolved

tex3d reviewed Mar 14, 2025

View reviewed changes

tools/clang/include/clang/Basic/DiagnosticSemaKinds.td Outdated Show resolved Hide resolved

add new warning group, rename files

337f120

bob80905 changed the title ~~[OMM] Implement front end diagnostics for OMM, including on TraceRayInline~~ [OMM] Implement front end diagnostics for OMM, including on TraceRayInline, and add Availability Attributes Mar 14, 2025

bob80905 added 3 commits March 13, 2025 19:28

add a test to disable default error behavior for new warnings

4cc865d

move decl insertion sooner

cea069a

refactor the 3 functions, remove null check

26694a8

tex3d reviewed Mar 14, 2025

View reviewed changes

tools/clang/test/SemaHLSL/rayquery-omm-type-diag.hlsl Outdated Show resolved Hide resolved

add static

7300142

tex3d approved these changes Mar 14, 2025

View reviewed changes

tex3d reviewed Mar 14, 2025

View reviewed changes

tools/clang/lib/Sema/SemaHLSLDiagnoseTU.cpp Outdated Show resolved Hide resolved

tex3d reviewed Mar 14, 2025

View reviewed changes

tools/clang/lib/Sema/SemaHLSLDiagnoseTU.cpp Outdated Show resolved Hide resolved

remove unnecessary build for entries, simplify type test

a0373db

tex3d approved these changes Mar 14, 2025

View reviewed changes

bob80905 merged commit 24dedfd into microsoft:main Mar 14, 2025
12 checks passed

github-project-automation bot moved this from New to Done in HLSL Roadmap Mar 14, 2025

damyanp moved this from Needs Review to Closed in HLSL Support Mar 19, 2025

[OMM] Implement front end diagnostics for OMM, including on TraceRayInline, and add Availability Attributes #7156

[OMM] Implement front end diagnostics for OMM, including on TraceRayInline, and add Availability Attributes #7156

Uh oh!

Conversation

bob80905 commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

damyanp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

damyanp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tex3d left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

damyanp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bob80905 commented Feb 24, 2025 •

edited

Loading

github-actions bot commented Feb 26, 2025 •

edited

Loading