Detour in NodeJS service (TypeScript calling C++)

[igupta-microsoft]

Hello all, my name is Ishita and I have recently started working with Detours for our NodeJS service.
I want to hook Detour to the winsock2 APIs "socket" and "closeSocket". The Detour is implemented in a .cc file which is compiled into a binary that is loaded into a TypeScript class using "require". Now the TypeScript class has a method that does a "fetch" call, and I am expecting the Detour to attach to the "socket" call that will happen in the background of "fetch" and replace it with my function. But I do see that the attachment is not happening. Can someone please give me some pointers as to what I might be doing wrong? I know that DetourAttach is happening successfully as DetourTransactionCommit is not returning any error.

Here's some code snippets for reference:

// C++ code
   BOOL WINAPI DllMain(HINSTANCE, DWORD dwReason, LPVOID)
   {
    
    switch (dwReason) {
    case DLL_PROCESS_ATTACH:
        DetourTransactionBegin();
        DetourUpdateThread(GetCurrentThread());
        DetourAttach(&(PVOID&)pSocket, mySocket);
        if (DetourTransactionCommit() == NO_ERROR)
            // std::cout << "connect() detoured successfully" << "\n";
            std::cout << "socket() detoured successfully" << "\n";

        DetourTransactionBegin();
        DetourUpdateThread(GetCurrentThread());
        DetourAttach(&(PVOID&)pCloseSocket, myCloseSocket);
        if (DetourTransactionCommit() == NO_ERROR)
            std::cout << "closeSocket() detoured successfully" << "\n";
        break;

    case DLL_PROCESS_DETACH:
        DetourTransactionBegin();
        DetourUpdateThread(GetCurrentThread());
        DetourDetach(&(PVOID&)pSocket, mySocket);
        DetourTransactionCommit();

        DetourTransactionBegin();
        DetourUpdateThread(GetCurrentThread());
        DetourDetach(&(PVOID&)pCloseSocket, myCloseSocket);
        DetourTransactionCommit();
        break;
    case DLL_THREAD_ATTACH:
    case DLL_THREAD_DETACH:
        break;
    }
    return TRUE;
}

int WINAPI myCloseSocket(SOCKET socket)
{
    std::cout << "myCloseSocket() detoured successfully";
    return pCloseSocket(socket);
}

SOCKET WINAPI mySocket(int af, int type, int protocol)
{
    std::cout<< "mySocket() detoured successfully\n";
    return pSocket(af, type, protocol);
}

The binding happens like this:

{
  'targets': [
    {
      'target_name': 'trafficintercept',
      'win_delay_load_hook': 'false',
      'sources': [
        'src/detourSockets.cc'
      ],
      'include_dirs' : [
        "<!(node -e \"require('nan')\")",
        './packages/Detours.4.0.1/lib/native/include'
      ],
      "libraries": [
        '../packages/Detours.4.0.1/lib/native/libs/x64/detours.lib'
      ]
    }
  ]
}

And then we use it in the TS class like this:

// TypeScript code
import fetch from 'node-fetch';
let binding = undefined;
// Don't block developers if SDK is not present
try {
    /* eslint-disable-next-line @typescript-eslint/no-require-imports */
    binding = require('./trafficintercept.node');
} catch {
}

export class DetourSockets {
    public detourSockets(): void {
        if (binding != null) {
            return binding.DetourSockets;
        }
        return null;
    }

    public async Test(): Promise<boolean> {
        console.log('started Test');
        const response = await fetch('https://www.microsoft.com');
        if (!response.ok) { return false; }
        return true;
    }
}