Update to typescript-eslint v8 #1082
Conversation
|
I have absolutely no idea why this is failing in CI and not locally :( |
|
I recall a previous PR of mine where that same rule was failing locally but not in CI. I don’t think I ended up figuring it out 😕 |
… check for this case
| const other = findTypesPackage(fileName); | ||
| return !other || other.dir !== pkg!.dir; |
There was a problem hiding this comment.
It turns out that this test explicitly includes files from other packages (including versioned subdirs) to test the rule, but we weren't actually checking this here. It's not clear to me why this wasn't breaking before, though.
There was a problem hiding this comment.
It's technically not the best to not cache this result, but since linting can be in an editor, we don't want to store a global cache or something. It shouldn't really cost that much.
|
This is all working now, though DT itself needs to be fixed to deal with the ban-types changes, so that will have to come later. |
|
I have no idea how but this PR broke publishing; it's repeatedly publishing deprecated packages that it's already deprecated. I've paused it until I can figure out what the heck is happening. |
ban-typesis out,no-unsafe-function-typeandno-wrapper-object-typesare in.DT will have to be updated to deal with this.