Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for launcher without SSH #6455

Merged

Conversation

dogacancolak-kensho
Copy link
Contributor

@tjruwase
Copy link
Contributor

@dogacancolak-kensho
Copy link
Contributor Author

I'm not getting any more errors with pre-commit run --all-files locally. Not sure which file has issues in the CI

@loadams
Copy link
Contributor

loadams commented Aug 28, 2024

I'm not getting any more errors with pre-commit run --all-files locally. Not sure which file has issues in the CI

Hi @dogacancolak-kensho - I pushed a fix, it appears that you have a local version of clang-format that is different than the one we use. I've been able to work around this in the past by using a venv to run the pre-commit formatter.

@loadams loadams added this pull request to the merge queue Aug 28, 2024
Merged via the queue into microsoft:master with commit 1041c8a Aug 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants