RNNprofiler: fix gates size retrieval logic in _rnn_flops #3921
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Sorry, this MR fixes a bug I introduced myself by mistaking the shape of
w_ih
to be(input_size, hidden_size)
, when in reality it is(N*hidden_size, input_size)
, whereN
differs depending on the RNN cell type (1 if RNN, 3 if GRU, 4 if LSTM).To avoid complexifying the logic, I went back to something very close to original implementation, simply multiplying by 2 for FLOP (instead of MAC) and subtracting what I called
gates_size = N * hidden_size
to avoid counting the bias twice.Thanks, and sorry for introducing another bug through my previous fix...
Cheers