Merge pull request #82 from microsoft/20241204_DriveInfoExceptionHandling

Disk Drive exception handling

Author: Malcolm-Stewart

SQLCheck/.vs/SQLCheck/v15/Server/sqlite3/storage.ide

@@ -1128,21 +1128,35 @@ public static void CollectDiskDrive(DataSet ds)
 
             int pctFree = 0;
 
-            foreach (DriveInfo drive in DriveInfo.GetDrives())
+            try
             {
-                DataRow DiskDrive = ds.Tables["DiskDrive"].NewRow();
-                DiskDrive["Drive"] = drive.Name;
-                DiskDrive["DriveType"] = drive.DriveType.ToString();
-                if (drive.IsReady)
+                foreach (DriveInfo drive in DriveInfo.GetDrives())
                 {
-                    DiskDrive["DriveFormat"] = drive.DriveFormat;
-                    DiskDrive["Capacity"] = drive.TotalSize.ToString("#,##0");
-                    DiskDrive["BytesFree"] = drive.TotalFreeSpace.ToString("#,##0");
-                    pctFree = (int)((drive.TotalFreeSpace * 100.0) / drive.TotalSize);
-                    DiskDrive["PctFree"] = $"{pctFree}%";
-                    if (pctFree < 10) DiskDrive["Message"] = "Low Disk Space";
+                    DataRow DiskDrive = ds.Tables["DiskDrive"].NewRow();
+                    try
+                    {
+                        ds.Tables["DiskDrive"].Rows.Add(DiskDrive);
+                        DiskDrive["Drive"] = drive.Name;
+                        DiskDrive["DriveType"] = drive.DriveType.ToString();
+                        if (drive.IsReady)
+                        {
+                            DiskDrive["DriveFormat"] = drive.DriveFormat;
+                            DiskDrive["Capacity"] = drive.TotalSize.ToString("#,##0");
+                            DiskDrive["BytesFree"] = drive.TotalFreeSpace.ToString("#,##0");
+                            pctFree = (int)((drive.TotalFreeSpace * 100.0) / drive.TotalSize);
+                            DiskDrive["PctFree"] = $"{pctFree}%";
+                            if (pctFree < 10) DiskDrive["Message"] = "Low Disk Space";
+                        }
+                    }
+                    catch (Exception ex)
+                    {
+                        DiskDrive.LogException("Error reading disk drive properties.", ex);
+                    }
                 }
-                ds.Tables["DiskDrive"].Rows.Add(DiskDrive);
+            }
+            catch (Exception ex2)
+            {
+                Computer.LogException("Error enumerating disk drives.", ex2);
             }
         }
 

SQLCheck/SQLCheck/Collectors.cs

@@ -10,7 +10,7 @@
 [assembly: AssemblyConfiguration("")]
 [assembly: AssemblyCompany("Microsoft Corporation - SQL Server Customer Support")]
 [assembly: AssemblyProduct("SQLCheck")]
-[assembly: AssemblyCopyright("Copyright ©  2021, 2022, 2023, 2024")]
+[assembly: AssemblyCopyright("Copyright ©  2021, 2022, 2023, 2024, 2025")]
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
 
@@ -32,5 +32,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.0.1437.0")]
-[assembly: AssemblyFileVersion("1.0.1437.0")]
+[assembly: AssemblyVersion("1.0.1438.0")]
+[assembly: AssemblyFileVersion("1.0.1438.0")]