SQLCheck upgrades

Warn when ERRORLOG shows mac connections exceeded.

Author: Malcolm-Stewart

SQLCheck/.vs/SQLCheck/v15/Server/sqlite3/storage.ide

@@ -933,31 +933,13 @@ public static void CollectProtocolOrder(DataSet ds)
             if (prot != null)
             {
                 string[] po = (string[])prot;
-                // RegStrings is before the annotation
                 ProtocolOrder["RegistryList"] = string.Join(",", po);
             }
 
             // From HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Microsoft\Cryptography\Configuration\SSL\00010002 ! Functions REG_SZ, comma-delimited
 
-            prot = Registry.GetValue(@"HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Microsoft\Cryptography\Configuration\SSL\00010002", "Functions", null);
+            ProtocolOrder["PolicyList"] = Registry.GetValue(@"HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Microsoft\Cryptography\Configuration\SSL\00010002", "Functions", "");
 
-            if (prot != null)
-            {
-                string[] po = (string[])prot;
-                // RegStrings is before the annotation
-                ProtocolOrder["PolicyList"] = string.Join(",", po);
-
-                // Warn if the Protocol List has entries that arent in the ReistryList
-                if (po.Length > 0)
-                {
-                    string[] RegStrings = ProtocolOrder.GetString("RegistryList").Trim().Split(',');
-                    string[] PolStrings = ProtocolOrder.GetString("PolicyList").Trim().Split(',');
-                    var comp = new StringIgnoreCaseComparer();
-                    var ExtraStrings = PolStrings.Except(RegStrings, comp);
-                    ExtraStrings.ToList().ForEach(s => ProtocolOrder.LogWarning($"Cipher Suite '{s}' appears in the Protocol List but not in the Registry List."));
-                }
-            }
-            
             // Warn if the Protocol List has entries that arent in the ReistryList
             if (ProtocolOrder.GetString("PolicyList").Trim().Length > 0)
             {
@@ -2098,7 +2080,14 @@ public static void CollectCertificate(DataSet ds)
                     if (cert.NotBefore > DateTime.Now) msg += ", Future cert";
                     Certificate["NotAfter"] = cert.NotAfter.ToString();
                     if (cert.NotAfter < DateTime.Now) msg += ", Expired cert";
-                    Certificate["KeySize"] = cert.PublicKey.Key.KeySize.ToString();
+                    try
+                    {
+                        Certificate["KeySize"] = cert.PublicKey.Key.KeySize.ToString();
+                    }
+                    catch (NotSupportedException)
+                    {
+                        msg += ", Unsupported key type";
+                    }
                     Certificate["SignatureAlgorithm"] = cert.SignatureAlgorithm.FriendlyName;
 
                     if (cert.PublicKey.Key.GetType().ToString() == "System.Security.Cryptography.RSACryptoServiceProvider")
@@ -3117,6 +3106,20 @@ public static void ProcessSQLErrorlog_File(DataRow SQLServer)  // must come prio
             searchText = "was successfully loaded for encryption.";
             SQLServer["Certificate"] = SmartString.GetStringLine(el, searchText, true);  // temporary holding place
 
+            line = SmartString.GetStringLine(el, "user connections has already been reached.");
+            if (line != "")
+            {
+                string userConnectionLimit = SmartString.GetBetween(line, "number of '", "'");
+                if (userConnectionLimit == "32767")
+                {
+                    SQLServer.LogWarning("SQL Server has recently reached the connection limit of 32767 connections.");
+                }
+                else
+                {
+                    SQLServer.LogWarning($"SQL Server has recently reached the connection limit of {userConnectionLimit} connections. This is lower than the 32767 upper limit.");
+                }
+            }
+
             bool alwaysOn = SmartString.GetStringLine(el, "Always On Availability Groups:") != "";
             SQLServer["AlwaysOn"] = alwaysOn;
 

SQLCheck/SQLCheck/Collectors.cs

@@ -32,5 +32,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.0.1305.0")]
-[assembly: AssemblyFileVersion("1.0.1305.0")]
+[assembly: AssemblyVersion("1.0.1309.0")]
+[assembly: AssemblyFileVersion("1.0.1309.0")]