-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reconnection scenarios and various behaviors of Direct Line ASE #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
changed the title
Fix Direct Line ASE (Streaming)
Fix reconnection scenarios and various behaviors of Direct Line ASE
Apr 26, 2023
tracyboehrer
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This pull request is to improve the DLASE chat adapter quality.
There are several issues found when we are pushing the quality bar.
Due to resources constraints, some tests are not done yet. The
TODO.md
list tests that need to be written, and areas that need to look at to make sure they are properly covered.Specific changes
jest@29.5.0
andjest-environment-jsdom@29.5.0
setupCrypto
as it is no longer needed in latestjsdom
babel-jest
as it is no longer requiredexpress
andhttp-proxy-middleware
to create a bot proxybotframework-streaming
for a development buildend()
is called, it should end all operations and no further reconnect/revival is allowedactivity$
should be completedconnectionStatus$
should becomeEnded
and completedreconnect()
should throw immediatelypostActivity()
postActivity()
succeeded, it shouldnext(activityId)
followed bycomplete()
postActivity()
failed, it shoulderror()
Connecting
orFailedToConnect
immediatelyreconnect()
is called, it will kick off connection if it is not already connectingreconnect()
will be no-opconnectionStatus$
should becomeFailedToConnect
FailedToConnect
is observed, call toreconnect()
will reset the retry counter and reconnectConnecting
once, despite it retry multiple times