[Node-Samples] Update to botbuilder 3.5.1 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update to botbuilder 3.5.1 - other dependencies updated as well - added new Media Cards (AnimationCard, VideoCard, AudioCard)
- update to botbuilder 3.5.1 - other dependencies updated as well - README - remove step not reproducible in emulator
- update to botbuilder 3.5.1 - other dependencies updated as well - updated library usage to match v3.5 style
- update to botbuilder 3.5.1 - other dependencies updated as well - updated to LUIS v2 endpoint
… features * Update to botbuilder 3.5.1 * Sample syntax updated to v3.5 style * Replace address dialog with BotBuilder-Location control * Localization for ContosoFlowers * README updates
* [Node-ReceiveAttachment] Update to support MS Teams attachments * [Node] README updates on Microsoft Teams support
|
Hi @pcostantini, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
Conflicts: Node/intelligence-LUIS/.env
weiligao
reviewed
Jan 15, 2017
| } | ||
| return session.message.attachments.length > 0 && | ||
| (session.message.attachments[0].contentType.indexOf('audio') === 0 || | ||
| session.message.attachments[0].contentType === 'video/mp4' || // FB sends audio streams as MP4 |
There was a problem hiding this comment.
Even though the code now allows processing of video/mp4 and audio/aac file formats as used in Facebook Messenger audio recordings and attachments, the Bing Speech API cannot handle these file formats and an error is returned.
There was a problem hiding this comment.
You are right! FB is re-encoding voice messages and audio attachments as MP4. Bing Speech API currently only supports WAV.
tracyboehrer
added a commit
that referenced
this pull request
Jul 8, 2021
* Java: Update samples and generators to 4.14.0 (#3354) * Python: Removed msrest dependency from #54 * Java: Updated to 4.14.0 * Java: Updated generator to 4.14.0 * Python: Updated generator dependencies to latest SDK (#3358) * Python: Removed msrest dependency from #54 (#3352) * Java: Updated sample 51 Teams manifest to match dotnet
tracyboehrer
added a commit
that referenced
this pull request
Jul 8, 2021
This reverts commit af5521a.
tracyboehrer
added a commit
that referenced
this pull request
Jul 8, 2021
This reverts commit af5521a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.