change max url length and add notes

Author: mdrichardson

samples/javascript_nodejs/80.skills-simple-bot-to-bot/simple-root-bot/index.js

@@ -123,8 +123,10 @@ const skillClient = new SkillHttpClient(credentialProvider, conversationIdFactor
 // Create the main dialog.
 const bot = new RootBot(conversationState, skillsConfig, skillClient);
 
-// Create HTTP server
-const server = restify.createServer();
+// Create HTTP server.
+// maxParamLength defaults to 100, which is too short for the conversationId created in skillConversationIdFactory
+// See: https://github.com/microsoft/BotBuilder-Samples/issues/2194
+const server = restify.createServer({ maxParamLength: 1000 });
 server.listen(process.env.port || process.env.PORT || 3978, function() {
     console.log(`\n${ server.name } listening to ${ server.url }`);
     console.log('\nGet Bot Framework Emulator: https://aka.ms/botframework-emulator');

samples/javascript_nodejs/80.skills-simple-bot-to-bot/simple-root-bot/skillConversationIdFactory.js

@@ -18,8 +18,8 @@ class SkillConversationIdFactory extends SkillConversationIdFactoryBase {
             conversationReference: TurnContext.getConversationReference(options.activity),
             oAuthScope: options.fromBotOAuthScope
         };
-        // This key has a 100 character limit.
-        const key = `${ options.fromBotId }-${ skillConversationReference.conversationReference.conversation.id }-skillconvo`;
+        // This key has a 100 character limit by default. Increase with `restify.createServer({ maxParamLength: 1000 });` in index.js
+        const key = `${ options.fromBotId }-${ options.botFrameworkSkill.appId }-${ skillConversationReference.conversationReference.conversation.id }-${ skillConversationReference.conversationReference.channelId }-skillconvo`;
         this.refs[key] = skillConversationReference;
         return key;
     }

samples/javascript_nodejs/81.skills-skilldialog/dialogRootBot/index.js

@@ -138,7 +138,9 @@ const mainDialog = new MainDialog(conversationState, skillsConfig, skillClient,
 const bot = new RootBot(conversationState, mainDialog);
 
 // Create HTTP server.
-const server = restify.createServer();
+// maxParamLength defaults to 100, which is too short for the conversationId created in skillConversationIdFactory
+// See: https://github.com/microsoft/BotBuilder-Samples/issues/2194
+const server = restify.createServer({ maxParamLength: 1000 });
 server.listen(process.env.port || process.env.PORT || 3978, function() {
     console.log(`\n${ server.name } listening to ${ server.url }`);
     console.log('\nGet Bot Framework Emulator: https://aka.ms/botframework-emulator');

samples/javascript_nodejs/81.skills-skilldialog/dialogRootBot/skillConversationIdFactory.js

@@ -18,8 +18,8 @@ class SkillConversationIdFactory extends SkillConversationIdFactoryBase {
             conversationReference: TurnContext.getConversationReference(options.activity),
             oAuthScope: options.fromBotOAuthScope
         };
-        // This key has a 100 character limit.
-        const key = `${ options.fromBotId }-${ skillConversationReference.conversationReference.conversation.id }-skillconvo`;
+        // This key has a 100 character limit by default. Increase with `restify.createServer({ maxParamLength: 1000 });` in index.js
+        const key = `${ options.fromBotId }-${ options.botFrameworkSkill.appId }-${ skillConversationReference.conversationReference.conversation.id }-${ skillConversationReference.conversationReference.channelId }-skillconvo`;
         this.refs[key] = skillConversationReference;
         return key;
     }