Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Cloud Role Name for Quickpulse SDK #2100

Merged
merged 10 commits into from
Oct 30, 2020

Conversation

rambhatt-msft
Copy link
Contributor

@rambhatt-msft rambhatt-msft commented Oct 27, 2020

Fix Issue # .

Changes

Added support for Cloud Role Name for Quickpulse SDK

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@rambhatt-msft rambhatt-msft marked this pull request as ready for review October 27, 2020 22:06
@TimothyMothra TimothyMothra added this to the 2.16 milestone Oct 27, 2020
Copy link
Member

@tokaplan tokaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@TimothyMothra
Copy link
Member

LGTM.

Please update the Changelog under the section "VNext"

Copy link
Contributor

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Wondering what is the actual UI change planned with this feature. Is it to do filtering? or show rolename, along with roleinstance in the charts?

@rambhatt-msft
Copy link
Contributor Author

@cijothomas

LGTM.
Wondering what is the actual UI change planned with this feature. Is it to do filtering? or show rolename, along with roleinstance in the charts?

Yes. The UX will let you see the roles and filter by them too. This is especially in our use case with AKS clusters where we can restrict roles that we dont want sending data and choking our service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants