-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Cloud Role Name for Quickpulse SDK #2100
Conversation
WEB/Src/PerformanceCollector/Perf.Tests/QuickPulse/QuickPulseServiceClientTests.cs
Show resolved
Hide resolved
WEB/Src/PerformanceCollector/Perf.Tests/QuickPulse/QuickPulseServiceClientTests.cs
Show resolved
Hide resolved
WEB/Src/PerformanceCollector/PerformanceCollector/QuickPulseTelemetryModule.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
WEB/Src/PerformanceCollector/Perf.Tests/QuickPulse/QuickPulseServiceClientTests.cs
Outdated
Show resolved
Hide resolved
LGTM. Please update the Changelog under the section "VNext" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Wondering what is the actual UI change planned with this feature. Is it to do filtering? or show rolename, along with roleinstance in the charts?
Yes. The UX will let you see the roles and filter by them too. This is especially in our use case with AKS clusters where we can restrict roles that we dont want sending data and choking our service |
Fix Issue # .
Changes
Added support for Cloud Role Name for Quickpulse SDK
Checklist
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:
Notes for reviewers:
/AzurePipelines run
will queue all builds/AzurePipelines run <pipeline-name>
will queue a specific build