disable dep collection required tests

microsoft · Aug 27, 2019 · 2f1427a · 2f1427a
1 parent b5eade0
commit 2f1427a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/...cationInsights.AspNetCore/DiagnosticListeners/Implementation/HostingDiagnosticListener.cs b/...cationInsights.AspNetCore/DiagnosticListeners/Implementation/HostingDiagnosticListener.cs
@@ -755,14 +755,19 @@ public void OnNext(KeyValuePair<string, object> value)
             else if (value.Key == "Microsoft.AspNetCore.Mvc.BeforeAction")
             {
                 var context = this.httpContextFetcherOnBeforeAction.Fetch(value.Value) as HttpContext;
-                var routeData = this.routeDataFetcher.Fetch(value.Value);
-                var routeValues = this.routeValuesFetcher.Fetch(routeData) as IDictionary<string, object>;
-
-                if (context != null && routeValues != null)
+                if (context != null)
                 {
-                    this.OnBeforeAction(context, routeValues);
-                }
+                    var routeData = this.routeDataFetcher.Fetch(value.Value);
+                    if (routeData != null)
+                    {
+                        var routeValues = this.routeValuesFetcher.Fetch(routeData) as IDictionary<string, object>;
 
+                        if (routeValues != null)
+                        {
+                            this.OnBeforeAction(context, routeValues);
+                        }
+                    }
+                }
             }
             else if (value.Key == "Microsoft.AspNetCore.Hosting.BeginRequest")
             {

diff --git a/test/WebApi20.FunctionalTests/FunctionalTest/MultipleWebHostsTests.cs b/test/WebApi20.FunctionalTests/FunctionalTest/MultipleWebHostsTests.cs
@@ -19,7 +19,7 @@ public MultipleWebHostsTests(ITestOutputHelper output) : base(output)
         {
         }
 
-        [Fact]
+        [Fact(Skip = "Re-Enable once DependencyTrackingModule is updated to latest DiagnosticSource.")]
         public void TwoWebHostsCreatedSequentially()
         {
             using (var server1 = new InProcessServer(assemblyName, this.output))
@@ -51,7 +51,7 @@ public void TwoWebHostsCreatedSequentially()
             }
         }
 
-        [Fact]
+        [Fact(Skip = "Re-Enable once DependencyTrackingModule is updated to latest DiagnosticSource.")]
         public void TwoWebHostsCreatedInParallel()
         {
             using (var server1 = new InProcessServer(assemblyName, this.output))