Add fix for hyphens in enum values#4202
Merged
harsimar merged 2 commits intomicrosoft:mainfrom May 8, 2025
Merged
Conversation
johnoliver
requested review from
TimothyMothra,
harsimar,
jeanbisutti,
rajkumar-rangaraj,
ramthi and
trask
as code owners
harsimar
reviewed
May 6, 2025
.../microsoft/applicationinsights/agent/internal/profiler/config/ProfilerConfigurationTest.java
Show resolved
Hide resolved
harsimar
approved these changes
May 6, 2025
Member
harsimar
left a comment
harsimar
left a comment
There was a problem hiding this comment.
The fix looks good, just a minor nit about the assertion in the test.
TimothyMothra
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix # .
For significant contributions please make sure you have completed the following items: