Support metric namespace #2447
Merged
Support metric namespace #2447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
support-metric-namespace
branch
2 times, most recently
from
95c3bae to
39dd837
Compare
trask
force-pushed
the
support-metric-namespace
branch
from
39dd837 to
a2fc8e6
Compare
heyams
reviewed
Aug 17, 2022
| String name, | ||
| String id, | ||
| String resultCode, | ||
| String duration, |
Contributor
There was a problem hiding this comment.
this doesn't seem right. i think you intended to rename Long totalMillis to Long duraiton (line 345)?
Member
Author
There was a problem hiding this comment.
ooops!! indeed that is what I meant to do
heyams
reviewed
Aug 17, 2022
| @Nullable Map<String, String> properties, | ||
| @Nullable Map<String, Double> metrics) { | ||
|
|
||
| if (isDisabled()) { |
Contributor
There was a problem hiding this comment.
it seems isDisabled() check is removed everywhere. Should we remove that boolean method too? It's only used in this class.
Member
Author
There was a problem hiding this comment.
it was kind of needed, because we used it in the bytecode instrumentation, but I agree that it's confusing, so I removed it, and if we need that feature in the future (to disable 2.x telemetry), it should be a json configuration option anyways
heyams
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently built on top of #2446, will rebase once that is merged.Resolves #2088
Resolves #1099