Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] support adding cross origin resource policy for #1851 #2423

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

siyuniu-ms
Copy link
Contributor

related to #1851

@MSNev MSNev self-requested a review September 27, 2024 00:55
@MSNev
Copy link
Collaborator

MSNev commented Sep 27, 2024

General comment on the timing of this change. Can you ask the backend people on the timeframe that they believe they will be able to implement this change as we should not commit this change until the backend supports it (and we validate that it's working), to avoid someone accidently enabling this and causing all requests to stop. As this will most likely cause an OPTIONS call (CORS validation) requesting whether the required header can be sent and if the server doesn't know anything about it the browser may block the call completely.

@MSNev MSNev added keep Do not Mark as Stale and close enhancement labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement keep Do not Mark as Stale and close
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants