Skip to content

Conversation

@sosharm
Copy link
Collaborator

@sosharm sosharm commented Apr 18, 2024

Related Issue

#8879

Description

The UWP/WinUI3 renderer only supports base64 svg images. Adding support for <svg>...</svg> format.
If the svg image is not in a base6 format, skip the decoding code and extract the svg data from the image url.

Sample Card

Updated Image.Svg.json

How Verified

Updated Image.Svg.json
image

@sosharm
Copy link
Collaborator Author

sosharm commented Apr 18, 2024

paulcam206
paulcam206 previously approved these changes Apr 22, 2024
Copy link
Member

@paulcam206 paulcam206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@jwoo-msft
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jwoo-msft jwoo-msft enabled auto-merge (squash) April 23, 2024 20:12
@jwoo-msft
Copy link
Member

/azp run uwp-ci.yml

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jwoo-msft jwoo-msft disabled auto-merge April 23, 2024 21:11
@jwoo-msft jwoo-msft merged commit 441e698 into microsoft:main Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants