Merge branch 'master' into feature/csproj_license

Author: BillWagner

.ghal.rules.json

@@ -10,7 +10,8 @@
       "(?i)dotnet-fsharp$": ":books: Area - F# Guide",
       "(?i)dotnet-ml$": ":books: Area - ML.NET Guide",
       "(?i)dotnet$": ":books: Area - .NET Guide",
-      "(?i)dotnet-ml-api$": ":books: Area - API Reference,:file_folder: Repo - ml-api-docs"
+      "(?i)dotnet-ml-api$": ":books: Area - API Reference,:file_folder: Repo - ml-api-docs",
+      "(?i)dotnet-roslyn-api$": ":books: Area - Roslyn API Reference,:file_folder: Repo - roslyn-api-docs",
     },
     "contentsource": {
       "(?i).*master\/docs\/core\/tools.*": ":card_file_box: Technology - CLI",
@@ -21,6 +22,7 @@
       "(?i).*master\/docs\/framework\/install.*": ":card_file_box: Technology - Installers",
       "(?i).*master\/docs\/framework\/migration-guide.*": ":card_file_box: Technology - AppCompat",
       "(?i).*master\/docs\/framework\/network-programming.*": ":card_file_box: Technology - NCL",
+      "(?i).*master\/docs\/framework\/windows-workflow-foundation.*": ":card_file_box: Technology - WF",
       "(?i).*master\/docs\/framework\/wpf.*": ":card_file_box: Technology - WPF",
       "(?i).*master\/docs\/framework\/wcf.*": ":card_file_box: Technology - WCF",
       "(?i).*master\/docs\/framework\/winforms.*": ":card_file_box: Technology - WinForms",

.github/CODEOWNERS

@@ -52,7 +52,7 @@
 # What's New
 /docs/framework/whats-new/** @rpetrusha
 # ADO.NET
-/docs/framework/data/adonet/** @douglaslMS
+/docs/framework/data/adonet/** @stevestein
 # NCL
 /docs/framework/configure-apps/file-schema/network/** @karelz
 /docs/framework/network-programming/** @karelz

.gitignore

@@ -28,6 +28,9 @@ _dependentPackages/
 # Visual Studio Code
 .vscode
 
+# Visual Studio 2019
+.vs
+
 # Windows thumbnail cache files
 Thumbs.db
 ehthumbs.db

.openpublishing.redirection.json

@@ -39,7 +39,7 @@ You can also choose from existing issues for which community contributions are w
 
 You can also look at our [open issues](https://github.com/dotnet/docs/issues) list and volunteer to work on the ones you're interested in. We use the [up-for-grabs](https://github.com/dotnet/docs/labels/up-for-grabs) label to tag issues open for contribution. 
 
-**Step 2:** Fork the `/dotnet/docs`, `dotnet/samples` or `dotnet/dotnet-api-docs` repos as needed and create a branch for your changes.
+**Step 2:** Fork the `dotnet/docs`, `dotnet/samples` or `dotnet/dotnet-api-docs` repos as needed and create a branch for your changes.
 
 For small changes, you can use GitHub's web interface. Simply click the **Edit the file in your fork of this project** on the file you'd like to change. 
 GitHub creates the new branch for you when you submit the changes.
@@ -106,7 +106,7 @@ contain a short description of the sample (one or two paragraphs). Your *readme.
 should tell readers what they will learn by exploring this sample. The *readme.md* file should also contain
 a link to the live document on the [.NET documentation site](https://docs.microsoft.com/dotnet/welcome).
 To determine where a given file in the repository maps to that site, replace `/docs` in the repository path
-with `http://docs.microsoft.com/dotnet/articles`.
+with `https://docs.microsoft.com/dotnet`.
 
 Your topic will also contain links to the sample. Link directly to the sample's folder on GitHub.
 
@@ -152,7 +152,7 @@ The following list shows some guiding rules that you should keep in mind when yo
 
 ## Contributor License Agreement
 
-You must sign the [.NET Foundation Contribution License Agreement (CLA)](https://cla.dotnetfoundation.org) before your PR is merged. This is a one-time requirement for projects in the .NET Foundation. You can read more about [Contribution License Agreements (CLA)](http://en.wikipedia.org/wiki/Contributor_License_Agreement) on Wikipedia.
+You must sign the [.NET Foundation Contribution License Agreement (CLA)](https://cla.dotnetfoundation.org) before your PR is merged. This is a one-time requirement for projects in the .NET Foundation. You can read more about [Contribution License Agreements (CLA)](https://en.wikipedia.org/wiki/Contributor_License_Agreement) on Wikipedia.
 
 The agreement: [net-foundation-contribution-license-agreement.pdf](https://github.com/dotnet/home/blob/master/guidance/net-foundation-contribution-license-agreement.pdf)
 

CONTRIBUTING.md

@@ -10,7 +10,7 @@ Issues and tasks for all three of those repositories are tracked here. We have a
 
 We welcome contributions to help us improve and complete the .NET docs. To contribute, see the [Projects for .NET Community Contributors](https://github.com/dotnet/docs/projects/35) for ideas. The [Contributing Guide](CONTRIBUTING.md) has instructions on procedures we use. Or, check the [issues list](https://github.com/dotnet/docs/issues) for tasks that interest you.
 
-We anticipate that [Xamarin](https://docs.microsoft.com/xamarin), [Mono](http://docs.go-mono.com/?link=root%3a%2fclasslib) and [Unity](http://docs.unity3d.com/Manual/index.html) will also use this documentation.
+We anticipate that [Xamarin](https://docs.microsoft.com/xamarin), [Mono](http://docs.go-mono.com/?link=root%3a%2fclasslib) and [Unity](https://docs.unity3d.com/Manual/index.html) will also use this documentation.
 
 This project has adopted the code of conduct defined by the Contributor Covenant
 to clarify expected behavior in our community.

README.md

@@ -1,4 +1,4 @@
-### YamlMime:XRefMap
+### YamlMime:XRefMap
 hrefUpdated: true
 references:
 - uid: System.Xml.Linq.XElement.Elements*
@@ -300,7 +300,7 @@ references:
   name: OvalShape
   name.vb: OvalShape
   fullName: Microsoft.VisualBasic.PowerPacks.OvalShape
-  fullName.vb: Microsoft.VisualBasic.PowerPacks.OvalShape 
+  fullName.vb: Microsoft.VisualBasic.PowerPacks.OvalShape
 - uid: Microsoft.VisualBasic.PowerPacks.Printing
   href: https://msdn.microsoft.com/library/microsoft.visualbasic.powerpacks.printing.aspx
   name: Microsoft.VisualBasic.PowerPacks.Printing
@@ -463,6 +463,12 @@ references:
   name.vb: TraceLevel
   fullName: PresentationTraceSources.TraceLevel
   fullName.vb: PresentationTraceSources.TraceLevel
+- uid: System.IO.WindowsRuntimeStreamExtensions
+  href: https://msdn.microsoft.com/library/system.io.windowsruntimestreamextensions.aspx
+  name: WindowsRuntimeStreamExtensions
+  name.vb: WindowsRuntimeStreamExtensions
+  fullName: System.IO.WindowsRuntimeStreamExtensions
+  fullName.vb: System.IO.WindowsRuntimeStreamExtensions
 - uid: System.IO.WindowsRuntimeStreamExtensions.AsInputStream*
   href: https://msdn.microsoft.com/library/system.io.windowsruntimestreamextensions.asinputstream.aspx
   name: AsInputStream
@@ -516,7 +522,7 @@ references:
   name: SetIsVirtualizing
   name.vb: SetIsVirtualizing
   fullName: VirtualizingStackPanel.SetIsVirtualizing
-  fullName.vb: VirtualizingStackPanel.SetIsVirtualizing  
+  fullName.vb: VirtualizingStackPanel.SetIsVirtualizing
 - uid: System.Windows.Localization.Attributes*
   href: https://msdn.microsoft.com/library/system.windows.localization.attributes.aspx
   name: Attributes
@@ -546,7 +552,7 @@ references:
   name: IsVisualHostMaterial
   name.vb: IsVisualHostMaterial
   fullName: Viewport2DVisual3D.IsVisualHostMaterial
-  fullName.vb: TimeViewport2DVisual3Dline.IsVisualHostMaterial  
+  fullName.vb: TimeViewport2DVisual3Dline.IsVisualHostMaterial
 - uid: System.Windows.Navigation.BaseUriHelper.BaseUri*
   href: https://msdn.microsoft.com/library/system.windows.navigation.baseurihelper.baseuri.aspx
   name: BaseUri
@@ -571,6 +577,12 @@ references:
   name.vb: VisualStateGroups
   fullName: VisualStateManager.VisualStateGroups
   fullName.vb: VisualStateManager.VisualStateGroups
+- uid: System.WindowsRuntimeSystemExtensions
+  href: https://msdn.microsoft.com/library/system.windowsruntimesystemextensions.aspx
+  name: WindowsRuntimeSystemExtensions
+  name.vb: WindowsRuntimeSystemExtensions
+  fullName: System.WindowsRuntimeSystemExtensions
+  fullName.vb: System.WindowsRuntimeSystemExtensions
 - uid: Microsoft.Office.Interop.Excel.Range
   href: https://msdn.microsoft.com/library/microsoft.office.interop.excel.range.aspx
   name: Range
@@ -600,4 +612,4 @@ references:
   name: XlRangeAutoFormat
   name.vb: XlRangeAutoFormat
   fullName: Microsoft.Office.Interop.Excel.XlRangeAutoFormat
-  fullName.vb: Microsoft.Office.Interop.Excel.XlRangeAutoFormat
+  fullName.vb: Microsoft.Office.Interop.Excel.XlRangeAutoFormat

_zip/missingapi.yml

@@ -16,7 +16,7 @@ install:
 build_script:
   # dotnet info
   - ps: dotnet --info
-  # Run dotnet new 
+  # Run dotnet new
   - ps: mkdir "test\test-dotnet-new" -Force | Push-Location
   - ps: dotnet new console -lang f#
   - ps: dotnet restore
@@ -25,5 +25,5 @@ build_script:
   - ps: Pop-Location
 
 
-test: off 
+test: off
 version: 0.0.1.{build}

appveyor.yml

@@ -104,7 +104,8 @@
     },
     "fileMetadata": {
       "feedback_system": {
-        "docs/standard/design-guidelines/**/**.md": "None"
+        "docs/standard/design-guidelines/**/**.md": "None",
+        "docs/framework/data/adonet/**/**.md": "None"
       },
       "feedback_product_url": {
         "docs/fsharp/**/**.md": "https://github.com/Microsoft/visualfsharp"
@@ -144,7 +145,7 @@
         "docs/csharp/**/**.yml": "billwagner",
         "docs/framework/configure-apps/file-schema/network/**/**.md": "karelz",
         "docs/framework/configure-apps/file-schema/wcf/**/**.md": "Lxiamail",
-        "docs/framework/data/adonet/**/**.md": "douglaslMS",
+        "docs/framework/data/adonet/**/**.md": "stevestein",
         "docs/framework/data/wcf/**/**.md": "Lxiamail",
         "docs/framework/network-programming/**/**.md": "karelz",
         "docs/framework/wcf/**/**.md": "Lxiamail",
@@ -161,7 +162,7 @@
         "docs/csharp/**/**.yml": "wiwagn",
         "docs/framework/configure-apps/file-schema/network/**/**.md": "ncldev",
         "docs/framework/configure-apps/file-schema/wcf/**/**.md": "wcfsrvt",
-        "docs/framework/data/adonet/**/**.md": "douglasl",
+        "docs/framework/data/adonet/**/**.md": "sstein",
         "docs/framework/data/wcf/**/**.md": "wcfsrvt",
         "docs/framework/network-programming/**/**.md": "ncldev",
         "docs/framework/wcf/**/**.md": "wcfsrvt",

docfx.json

@@ -89,7 +89,7 @@ It is perhaps easiest to understand the size and shape of .NET Core by comparing
 
 The major differences between .NET Core and the .NET Framework:
 
-- **App-models** -- .NET Core does not support all the .NET Framework app-models. In particular, it doesn't support ASP.NET Web Forms and MVC. It was announced that [.NET Core 3 will support WPF and Windows Forms](https://blogs.msdn.microsoft.com/dotnet/2018/05/07/net-core-3-and-support-for-windows-desktop-applications/).
+- **App-models** -- .NET Core does not support all the .NET Framework app-models. In particular, it doesn't support ASP.NET Web Forms and ASP.NET MVC, but it supports ASP.NET Core MVC. It was announced that [.NET Core 3 will support WPF and Windows Forms](https://blogs.msdn.microsoft.com/dotnet/2018/05/07/net-core-3-and-support-for-windows-desktop-applications/).
 - **APIs** -- .NET Core contains a large subset of .NET Framework Base Class Library, with a different factoring (assembly names are different; members exposed on types differ in key cases). These differences require changes to port source to .NET Core in some cases (see [microsoft/dotnet-apiport](https://github.com/microsoft/dotnet-apiport)). .NET Core implements the [.NET Standard](../standard/net-standard.md) API specification.
 - **Subsystems** -- .NET Core implements a subset of the subsystems in the .NET Framework, with the goal of a simpler implementation and programming model. For example, Code Access Security (CAS) is not supported, while reflection is supported.
 - **Platforms** -- The .NET Framework supports Windows and Windows Server while .NET Core also supports macOS and Linux.

docs/core/about.md

@@ -2,7 +2,7 @@
 title: WCF svcutil tool overview
 description: An overview of the Microsoft WCF dotnet-svcutil tool that adds functionality for .NET Core and ASP.NET Core projects, similar to the WCF svcutil tool for .NET Framework projects.
 author: mlacouture
-ms.date: 08/20/2018
+ms.date: 02/22/2019
 ms.custom: "seodec18"
 ---
 # WCF dotnet-svcutil tool for .NET Core
@@ -18,12 +18,19 @@ The **dotnet-svcutil** tool is an alternative option to the [**WCF Web Service R
 
 ## Prerequisites
 
-* [.NET Core SDK](https://dotnet.microsoft.com/download) v1.0.4 or later versions
+# [dotnet-svcutil 2.x](#tab/dotnetsvcutil2x)
+* [.NET Core 2.1 SDK](https://dotnet.microsoft.com/download) or later versions
 * Your favorite code editor
 
+# [dotnet-svcutil 1.x](#tab/dotnetsvcutil1x)
+* [.NET Core 1.0.4 SDK](https://dotnet.microsoft.com/download) or later versions
+* Your favorite code editor
+
+---
+
 ## Getting started
 
-The following example walks you through the steps required to add a web service reference to a .NET Core console project and invoke the service. You will create a .NET Core console application named _HelloSvcutil_ and will add a reference to a web service that implements the following contract:
+The following example walks you through the steps required to add a web service reference to a .NET Core web project and invoke the service. You'll create a .NET Core web application named _HelloSvcutil_ and add a reference to a web service that implements the following contract:
 
 ```csharp
 [ServiceContract]
@@ -34,7 +41,7 @@ public interface ISayHello
 }
 ```
 
-For this example, the web service will be assumed to be hosted at the following address: `http://contoso.com/SayHello.svc`
+For this example, let's assume the web service will be hosted at the following address: `http://contoso.com/SayHello.svc`
 
 From a Windows, macOS, or Linux command window perform the following steps:
 
@@ -45,73 +52,116 @@ mkdir HelloSvcutil
 cd HelloSvcutil
 ```
 
-2. Create a new C# console project in that directory using the [`dotnet new`](../tools/dotnet-new.md) command as follows:
+2. Create a new C# web project in that directory using the [`dotnet new`](../tools/dotnet-new.md) command as follows:
+
+```console
+dotnet new web
+```
 
+3. Install the [`dotnet-svcutil` NuGet package](https://nuget.org/packages/dotnet-svcutil) as a CLI tool:
+# [dotnet-svcutil 2.x](#tab/dotnetsvcutil2x)
 ```console
-dotnet new console
+dotnet tool install --global dotnet-svcutil
 ```
 
-3. Open the `HelloSvcutil.csproj` project file in your editor, edit the `Project` element, and add the [`dotnet-svcutil` NuGet package](https://nuget.org/packages/dotnet-svcutil) as a CLI tool reference, using the following code:
+# [dotnet-svcutil 1.x](#tab/dotnetsvcutil1x)
+Open the `HelloSvcutil.csproj` project file in your editor, edit the `Project` element, and add the [`dotnet-svcutil` NuGet package](https://nuget.org/packages/dotnet-svcutil) as a CLI tool reference, using the following code:
 
 ```xml
 <ItemGroup>
   <DotNetCliToolReference Include="dotnet-svcutil" Version="1.0.*" />
 </ItemGroup>
 ```
 
-4. Restore the _dotnet-svcutil_ package using the [`dotnet restore`](../tools/dotnet-restore.md) command as follows:
+Then restore the _dotnet-svcutil_ package using the [`dotnet restore`](../tools/dotnet-restore.md) command as follows:
 
 ```console
 dotnet restore
 ```
 
-5. Run _dotnet_ with the _svcutil_ command to generate the web service reference file as follows:
+---
+
+4. Run the _dotnet-svcutil_ command to generate the web service reference file as follows:
+# [dotnet-svcutil 2.x](#tab/dotnetsvcutil2x)
+```console
+dotnet-svcutil http://contoso.com/SayHello.svc
+```
 
+# [dotnet-svcutil 1.x](#tab/dotnetsvcutil1x)
 ```console
 dotnet svcutil http://contoso.com/SayHello.svc
 ```
-The generated file is saved as _HelloSvcutil/ServiceReference1/Reference.cs_. The _dotnet_svcutil_ tool also adds to the project the appropriate WCF packages required by the proxy code as package references.
+---
+
+The generated file is saved as _HelloSvcutil/ServiceReference/Reference.cs_. The _dotnet-svcutil_ tool also adds to the project the appropriate WCF packages required by the proxy code as package references.
 
-6. Restore the WCF packages using the [`dotnet restore`](../tools/dotnet-restore.md) command as follows:
+## Using the Service Reference
+
+1. Restore the WCF packages using the [`dotnet restore`](../tools/dotnet-restore.md) command as follows:
 
 ```console
 dotnet restore
 ```
 
-7. Open the `Program.cs` file in your editor, edit the `Main()` method, and replace the auto-generated code with the following code to invoke the web service:
+2. Find the name of the client class and operation you want to use. `Reference.cs` will contain a class that inherits from `System.ServiceModel.ClientBase`, with methods that can be used to call operations on the service. In this example, you want to call the _SayHello_ service's _Hello_ operation. `ServiceReference.SayHelloClient` is the name of the client class, and has a method called `HelloAsync` that can be used to call the operation.
+
+3. Open the `Startup.cs` file in your editor, and add a using statement for the service reference namespace at the top:
 
 ```csharp
-static void Main(string[] args)
+using ServiceReference;
+```
+
+ 4. Edit the `Configure` method to invoke the web service. You do this by creating an instance of the class that inherits from `ClientBase` and calling the method on the client object:
+
+```csharp
+public void Configure(IApplicationBuilder app, IHostingEnvironment env)
 {
-    var client = new SayHelloClient();
-    Console.WriteLine(client.HelloAsync("dotnet-svcutil").Result);
+    if (env.IsDevelopment())
+    {
+        app.UseDeveloperExceptionPage();
+    }
+
+    app.Run(async (context) =>
+    {
+        var client = new SayHelloClient();
+        var response = await client.HelloAsync();
+        await context.Response.WriteAsync(response);
+    });
 }
+
 ```
 
-8. Run the application using the [`dotnet run`](../tools/dotnet-run.md) command as follows:
+5. Run the application using the [`dotnet run`](../tools/dotnet-run.md) command as follows:
 
 ```console
 dotnet run
 ```
+
+6. Navigate to the URL listed in the console (for example, `http://localhost:5000`) in your web browser.
+
 You should see the following output:
 "Hello dotnet-svcutil!"
 
 For a detailed description of the `dotnet-svcutil` tool parameters, invoke the tool passing the help parameter as follows:
+# [dotnet-svcutil 2.x](#tab/dotnetsvcutil2x)
+```console
+dotnet-svcutil --help
+```
 
+# [dotnet-svcutil 1.x](#tab/dotnetsvcutil1x)
 ```console
 dotnet svcutil --help
 ```
+---
 
-## Next steps
-
-### Feedback & questions
+## Feedback & questions
 
 If you have any questions or feedback, [open an issue on GitHub](https://github.com/dotnet/wcf/issues/new). You can also review any existing questions or issues [at the WCF repo on GitHub](https://github.com/dotnet/wcf/issues?utf8=%E2%9C%93&q=is:issue%20label:tooling).
 
-### Release notes
+## Release notes
 
 * Refer to the [Release notes](https://github.com/dotnet/wcf/blob/master/release-notes/dotnet-svcutil-notes.md) for updated release information, including known issues.
 
-### Information
+## Information
 
 * [dotnet-svcutil NuGet Package](https://nuget.org/packages/dotnet-svcutil)

docs/core/additional-tools/dotnet-svcutil-guide.md

@@ -96,6 +96,6 @@ Use the `dotnet` executable from *artifacts/{os}-{arch}/stage2* to try out the n
 
 ## See also
 
-* [.NET Core Common Language Runtime (CoreCLR)](https://github.com/dotnet/coreclr/blob/master/README.md)
-* [.NET Core CLI Developer Guide](https://github.com/dotnet/cli/blob/master/Documentation/project-docs/developer-guide.md)
-* [.NET Core distribution packaging](./distribution-packaging.md)
+- [.NET Core Common Language Runtime (CoreCLR)](https://github.com/dotnet/coreclr/blob/master/README.md)
+- [.NET Core CLI Developer Guide](https://github.com/dotnet/cli/blob/master/Documentation/project-docs/developer-guide.md)
+- [.NET Core distribution packaging](./distribution-packaging.md)