Skip to content

README: Fix typos. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2016
Merged

README: Fix typos. #18

merged 1 commit into from
Oct 25, 2016

Conversation

mcauser
Copy link
Contributor

@mcauser mcauser commented Oct 23, 2016

No description provided.

@@ -16,7 +16,7 @@ own network).
At this time, WebREPL client cannot be accessed over HTTPS connection.
This is due to not widely published policy that HTTPS pages may
access only WSS (WebSocket Secure) protocol. This is somewhat
similar to warnings issues when e.g. an HTTPS paeg loads an image
similar to warnings issues when e.g. a HTTPS page loads an image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it should be "an HTTPS page" because you pronounce it as "aich tee tee pee ess", see eg http://blog.apastyle.org/apastyle/2012/04/using-a-or-an-with-acronyms-and-abbreviations.html

Copy link
Contributor Author

@mcauser mcauser Oct 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -16,7 +16,7 @@ own network).
At this time, WebREPL client cannot be accessed over HTTPS connection.
This is due to not widely published policy that HTTPS pages may
access only WSS (WebSocket Secure) protocol. This is somewhat
similar to warnings issues when e.g. an HTTPS paeg loads an image
similar to warnings issues when e.g. an HTTPS page loads an image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that "issues" should be "issued"... don't you agree?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Also a few others.

@pfalcon
Copy link
Contributor

pfalcon commented Oct 24, 2016

... And commits should be squashed to one, with update commit message as needed.

@mcauser mcauser changed the title README: Fix typo. README: Fix typos. Oct 24, 2016
@@ -91,7 +91,7 @@ communicate terminal input and output between a client and a WebREPL-
enabled device (server). There's a guaranteed password prompt, which
can be detected by the appearance of characters ':', ' ' (at this
point, server expected a password ending with '\n' from client).
If you're interested to develop a 3rd-party application to communicate
If you're interested in developing a 3rd-party application to communicate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but this is correct in grammar and equivalent in meaning ;-).

@pfalcon pfalcon merged commit f8dbf12 into micropython:master Oct 25, 2016
@pfalcon
Copy link
Contributor

pfalcon commented Oct 25, 2016

Merged, thanks. @mcauser , if you'd like to patch javascript to issue that warning about ws: vs wss: thing, don't hesitate to ;-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants