-
Notifications
You must be signed in to change notification settings - Fork 299
README: Fix typos. #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -16,7 +16,7 @@ own network). | |||
At this time, WebREPL client cannot be accessed over HTTPS connection. | |||
This is due to not widely published policy that HTTPS pages may | |||
access only WSS (WebSocket Secure) protocol. This is somewhat | |||
similar to warnings issues when e.g. an HTTPS paeg loads an image | |||
similar to warnings issues when e.g. a HTTPS page loads an image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it should be "an HTTPS page" because you pronounce it as "aich tee tee pee ess", see eg http://blog.apastyle.org/apastyle/2012/04/using-a-or-an-with-acronyms-and-abbreviations.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -16,7 +16,7 @@ own network). | |||
At this time, WebREPL client cannot be accessed over HTTPS connection. | |||
This is due to not widely published policy that HTTPS pages may | |||
access only WSS (WebSocket Secure) protocol. This is somewhat | |||
similar to warnings issues when e.g. an HTTPS paeg loads an image | |||
similar to warnings issues when e.g. an HTTPS page loads an image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that "issues" should be "issued"... don't you agree?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Also a few others.
... And commits should be squashed to one, with update commit message as needed. |
@@ -91,7 +91,7 @@ communicate terminal input and output between a client and a WebREPL- | |||
enabled device (server). There's a guaranteed password prompt, which | |||
can be detected by the appearance of characters ':', ' ' (at this | |||
point, server expected a password ending with '\n' from client). | |||
If you're interested to develop a 3rd-party application to communicate | |||
If you're interested in developing a 3rd-party application to communicate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but this is correct in grammar and equivalent in meaning ;-).
Merged, thanks. @mcauser , if you'd like to patch javascript to issue that warning about ws: vs wss: thing, don't hesitate to ;-). |
No description provided.