Introduce KafkaListener.threadsValue to allow for dynamic config
#769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillermocalvo
added
type: improvement
jeremyg484
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Looks good, though it is a breaking change as noted.
If we don't want to force another major version bump for something this simple, an alternate approach would be to keep the existing attribute as an int and add an alternate attribute to the annotation that is a String.
@sdelamo What do you think?
sdelamo
previously requested changes
Jul 19, 2023
|
I would keep it as an int and introduce |
guillermocalvo
changed the title
KafkaListener.threads as a String to allow for dynamic configKafkaListener.threadsValue to allow for dynamic config
jeremyg484
suggested changes
Jul 19, 2023
kafka/src/test/groovy/io/micronaut/configuration/kafka/annotation/KafkaListenerSpec.groovy
Show resolved
Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/processor/KafkaConsumerProcessor.java
Outdated
Show resolved
Hide resolved
jeremyg484
approved these changes
Jul 19, 2023
We use only one field to read the value
dstepanov
approved these changes
Jul 26, 2023
sdelamo
approved these changes
Aug 4, 2023
guillermocalvo
deleted the
689-is-there-any-way-to-set-kafkalistenerthreads-using-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #689