Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Injecting kafka producer beans using @KafkaClient doesn't use the configuration on the annotation #247

Closed
fromlabs opened this issue Sep 25, 2020 · 1 comment · Fixed by #589
Closed

Injecting kafka producer beans using @KafkaClient doesn't use the configuration on the annotation #247

fromlabs opened this issue Sep 25, 2020 · 1 comment · Fixed by #589
Assignees
@msupic
Labels
priority: high High priority type: bug Something isn't working
Milestone
4.4.1

Comments

@fromlabs
Copy link

Steps to Reproduce

  1. Create BookSender class and inject kafka producer bean
  2. Add acks attribute to @KafkaClient("book-producer", acks = KafkaClient.Acknowledge.ALL)
  3. Create a test with embedded kafka
  4. Collect producer config logs

Expected Behaviour

Producer acks property should be -1 (ALL ack).

Actual Behaviour

Producer acks property is 1 as the default configuration.

18:58:03.174 [main] INFO  o.a.k.c.producer.ProducerConfig - ProducerConfig values: 
	acks = 1
	batch.size = 16384
	bootstrap.servers = [localhost:9092]

Environment Information

  • Operating System: macOS
  • Micronaut Version: 2.0.3
  • Micronaut Kafka Version: 3.0.0
  • JDK Version: 11.0.1

Example Application
@graemerocher graemerocher added type: bug Something isn't working priority: high High priority labels Mar 1, 2021
@msupic msupic self-assigned this Aug 15, 2022
msupic added a commit that referenced this issue Aug 18, 2022
@msupic
Injecting kafka producer beans using @KafkaClient doesn't use the con…
520a3c1 
…figuration on the annotation (#247)
msupic added a commit that referenced this issue Aug 30, 2022
@msupic
Injecting kafka producer beans using @KafkaClient doesn't use the con…
03ba253 
…figuration on the annotation (#247) (#589)

* Injecting kafka producer beans using @KafkaClient doesn't use the configuration on the annotation (#247)

* Used CollectionUtils to check whether the props map is empty or not
@msupic msupic linked a pull request Aug 30, 2022 that will close this issue
Injecting kafka producer beans using @KafkaClient doesn't use the configuration on the annotation (#247) #589
Merged
@msupic msupic added this to the 4.4.1 milestone Aug 30, 2022
@guillermocalvo
Copy link
Contributor

Closed by #589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msupic msupic

Labels
priority: high High priority type: bug Something isn't working
Projects
None yet
Milestone
4.4.1
4 participants
@graemerocher @guillermocalvo @fromlabs @msupic