Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: typo in javadoc for @Transactional #3098

Open
mikehearn opened this issue Sep 2, 2024 · 0 comments
Open

Docs: typo in javadoc for @Transactional #3098

mikehearn opened this issue Sep 2, 2024 · 0 comments

Comments

@mikehearn
Copy link

mikehearn commented Sep 2, 2024

rollbackFor docs should be the exceptions that do trigger a rollback.

    /**
     * Defines the exceptions that will not result in a rollback.
     *
     * @return The exception types that will not result in a rollback.
     * @since 3.5.0
     */
    Class<? extends Throwable>[] rollbackFor() default {};

This is confusing because it's unclear what happens if an exception is neither in the rollbackFor nor noRollbackFor lists. It ideally would be clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant