Refactor the Gradle build #7048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melix
added
the
relates-to: build
This commit refactors the Gradle build to use the new Micronaut build plugins and move it to the new build template (which makes use of convention plugins). The build is obviously more complex than for external Micronaut modules, in particular because some modules are providing core functionalities but also depend on external Micronaut modules for tests (e.g Micronaut Test).
melix
force-pushed
the
cc/migrate-build-plugins
branch
from
271f8b0 to
bf1fa81
Compare
|
@timyates please check this PR. I would like to move this forward for 3.4.1 |
alvarosanchez
approved these changes
Mar 22, 2022
sdelamo
requested changes
Mar 23, 2022
| ext { | ||
| shadowJarEnabled = true | ||
| plugins { | ||
| id "io.micronaut.build.internal.convention-core-library" |
There was a problem hiding this comment.
why is session a core library? I assume you added because shadowJarEnabled=true but does it need to be a core library?
There was a problem hiding this comment.
That is simply remodeling what existed before, session was treated differently like the other core-library. I am not familiar enough with that module to say if it should be done differently.
There was a problem hiding this comment.
It was added here: https://github.com/micronaut-projects/micronaut-core/pull/1486/files
buildSrc/src/main/groovy/io/micronaut/build/internal/ext/DefaultMicronautCoreExtension.java
Show resolved
Hide resolved
|
The build won't pass: after upgrading to build tools 5.3.0 it now detects binary breaking changes:
|
|
For clarity here are the BOM validation problems which are now detected: https://ge.micronaut.io/s/zphruxszgq6d4/console-log#L560-L579 |
|
I have added suppressions for the problems above and created issues in the respective problematic projects. |
Ok, after I merge it I will create a PR to remove the suppressions in a different PR. So that we don't forget. |
You'll have to keep the r2dbc one. |
Should not we keep the r2dbc suppression in the 2rdbc module instead? |
You need both: validation will fail in the r2dbc module, but it will also fail here since we check transitively. |
|
Kudos, SonarCloud Quality Gate passed!
|
sdelamo
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the Gradle build to use the new Micronaut
build plugins and move it to the new build template (which makes
use of convention plugins).
The build is obviously more complex than for external Micronaut
modules, in particular because some modules are providing core
functionalities but also depend on external Micronaut modules
for tests (e.g Micronaut Test).