Fix env package name in expression language type identifier #11418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on fixing #11410
The root of the issue seems to be from
Tokenizer.getNextToken()coupled with howSingleEvaluatedExpressionParser.typeIdentifier()loops through the identifiers.Tokenizer.getNextToken()has an order in which it checks for token types, when this is called to find the lookahead it doesn't seem to take into account what the previous token was which might be important for things like this type identifier.While the solution of checking for multiple token types specifically for
typeIdentifier()works, it doesn't feel very optimal. Right now it only checksIDENTIFIERorENVIRONMENTfor this specific example, but it should likely also include things likectx, or any other expected package naming that could trigger another token type if this approach is what gets adopted.