-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: micronaut-projects/micronaut-core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.7.11
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: micronaut-projects/micronaut-core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.7.12
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 5 commits
- 10 files changed
- 3 contributors
Commits on Jan 8, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 01ca841 - Browse repository at this point
Copy the full SHA 01ca841View commit details
Commits on Jan 15, 2025
-
test: ignore FormUrlEncodedBodyInRequestFilterTest for HTTP 2 (#11508)
The test is flaky for HTTP 2: https://ge.micronaut.io/scans/tests?search.buildOutcome=failure&search.rootProjectNames=micronaut-parent&search.tags=ci&search.timeZoneId=Europe%2FMadrid&tests.container=io.micronaut.http.server.tck.tests.forms.FormUrlEncodedBodyInRequestFilterTest&tests.test=bodyParsingInFilter()&tests.unstableOnly=false I don’t think it is that the test is badly written. I think it is an underlying issue of the HTTP2 path: https://ge.micronaut.io/s/vllxe5czbs5jw/tests/task/:test-suite-http2-server-tck-netty:test/details/io.micronaut.http.server.tck.tests.forms.FormUrlEncodedBodyInRequestFilterTest/bodyParsingInFilter()/1/output ``` 00:57:25.989 [Test worker] INFO i.m.c.DefaultApplicationContext$RuntimeConfiguredEnvironment - Established active environments: [test] 00:57:26.033 [Test worker] WARN i.m.http.ssl.SslConfiguration - The configuration micronaut.ssl.port is deprecated. Use micronaut.server.ssl.port instead. 00:57:26.920 [Test worker] WARN i.m.h.c.n.ssl.NettyClientSslBuilder - HTTP Client is configured to trust all certificates ('insecure-trust-all-certificates' is set to true). Trusting all certificates is not secure and should not be used in production. 00:57:26.997 [Test worker] INFO i.m.c.DefaultApplicationContext$RuntimeConfiguredEnvironment - Established active environments: [test] 00:57:27.038 [Test worker] WARN i.m.http.ssl.SslConfiguration - The configuration micronaut.ssl.port is deprecated. Use micronaut.server.ssl.port instead. 00:57:27.646 [Test worker] WARN i.m.h.c.n.ssl.NettyClientSslBuilder - HTTP Client is configured to trust all certificates ('insecure-trust-all-certificates' is set to true). Trusting all certificates is not secure and should not be used in production. 00:57:27.754 [Test worker] INFO i.m.c.DefaultApplicationContext$RuntimeConfiguredEnvironment - Established active environments: [test] 00:57:27.811 [Test worker] WARN i.m.http.ssl.SslConfiguration - The configuration micronaut.ssl.port is deprecated. Use micronaut.server.ssl.port instead. 00:57:28.019 [Test worker] WARN i.m.h.c.n.ssl.NettyClientSslBuilder - HTTP Client is configured to trust all certificates ('insecure-trust-all-certificates' is set to true). Trusting all certificates is not secure and should not be used in production. 00:57:28.079 [default-nioEventLoopGroup-140-4] WARN i.m.h.s.netty.RoutingInBoundHandler - Failed to build error response java.lang.AssertionError: null at io.micronaut.http.body.stream.BaseSharedBuffer.subscribe0(BaseSharedBuffer.java:205) at io.micronaut.http.netty.body.StreamingNettyByteBody$SharedBuffer.subscribe(StreamingNettyByteBody.java:259) at io.micronaut.http.netty.body.StreamingNettyByteBody.close(StreamingNettyByteBody.java:177) at io.micronaut.http.server.netty.NettyHttpRequest.release(NettyHttpRequest.java:388) at io.micronaut.http.server.netty.RoutingInBoundHandler.cleanupRequest(RoutingInBoundHandler.java:161) at io.micronaut.http.server.netty.RoutingInBoundHandler.responseWritten(RoutingInBoundHandler.java:178) at io.micronaut.http.server.netty.websocket.NettyServerWebSocketUpgradeHandler.responseWritten(NettyServerWebSocketUpgradeHandler.java:167) at io.micronaut.http.server.netty.handler.MultiplexedServerHandler$MultiplexedStream.finish(MultiplexedServerHandler.java:234) at io.micronaut.http.server.netty.handler.MultiplexedServerHandler$MultiplexedStream.writeFull(MultiplexedServerHandler.java:383) at io.micronaut.http.server.netty.handler.MultiplexedServerHandler$MultiplexedStream.write(MultiplexedServerHandler.java:260) at io.micronaut.http.server.netty.RoutingInBoundHandler.lambda$writeResponse$0(RoutingInBoundHandler.java:298) at io.micronaut.core.execution.ImperativeExecutionFlowImpl.onComplete(ImperativeExecutionFlowImpl.java:132) at io.micronaut.http.server.netty.RoutingInBoundHandler.writeResponse(RoutingInBoundHandler.java:274) at io.micronaut.http.server.netty.NettyRequestLifecycle.lambda$handleNormal$0(NettyRequestLifecycle.java:107) at io.micronaut.core.execution.ImperativeExecutionFlowImpl.onComplete(ImperativeExecutionFlowImpl.java:132) at io.micronaut.core.execution.DelayedExecutionFlowImpl$OnComplete.apply(DelayedExecutionFlowImpl.java:379) at io.micronaut.core.execution.DelayedExecutionFlowImpl.work(DelayedExecutionFlowImpl.java:54) at io.micronaut.core.execution.DelayedExecutionFlowImpl.complete0(DelayedExecutionFlowImpl.java:72) at io.micronaut.core.execution.DelayedExecutionFlowImpl.complete(DelayedExecutionFlowImpl.java:78) at io.micronaut.http.body.stream.BaseSharedBuffer.subscribeFull0(BaseSharedBuffer.java:276) at io.micronaut.http.netty.body.StreamingNettyByteBody$SharedBuffer.lambda$subscribeFull$2(StreamingNettyByteBody.java:322) at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:173) at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:166) at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472) at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:569) at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.base/java.lang.Thread.run(Thread.java:1583) 00:57:38.077 [default-nioEventLoopGroup-140-3] WARN i.n.c.AbstractChannelHandlerContext - An exception 'java.lang.IllegalStateException: Already completed' [enable DEBUG level for full stacktrace] was thrown by a user handler's exceptionCaught() method while handling the following exception: java.lang.IllegalStateException: Already completed at io.micronaut.core.execution.DelayedExecutionFlowImpl$Step.atomicSetOutput(DelayedExecutionFlowImpl.java:217) at io.micronaut.core.execution.DelayedExecutionFlowImpl.work(DelayedExecutionFlowImpl.java:55) at io.micronaut.core.execution.DelayedExecutionFlowImpl.complete0(DelayedExecutionFlowImpl.java:72) at io.micronaut.core.execution.DelayedExecutionFlowImpl.completeExceptionally(DelayedExecutionFlowImpl.java:83) at io.micronaut.http.client.netty.DefaultHttpClient$6.fail(DefaultHttpClient.java:1702) at io.micronaut.http.client.netty.Http1ResponseHandler$BeforeResponse.exceptionCaught(Http1ResponseHandler.java:147) at io.micronaut.http.client.netty.Http1ResponseHandler$ReaderState.channelInactive(Http1ResponseHandler.java:112) at io.micronaut.http.client.netty.Http1ResponseHandler.channelInactive(Http1ResponseHandler.java:83) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:303) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:281) at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:274) at io.netty.channel.ChannelInboundHandlerAdapter.channelInactive(ChannelInboundHandlerAdapter.java:81) at io.netty.handler.codec.http.HttpContentDecoder.channelInactive(HttpContentDecoder.java:235) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:303) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:281) at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:274) at io.netty.channel.DefaultChannelPipeline$HeadContext.channelInactive(DefaultChannelPipeline.java:1352) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:301) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:281) at io.netty.channel.DefaultChannelPipeline.fireChannelInactive(DefaultChannelPipeline.java:850) at io.netty.handler.codec.http2.AbstractHttp2StreamChannel$Http2ChannelUnsafe$2.run(AbstractHttp2StreamChannel.java:797) at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:173) at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:166) at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472) at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:569) at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.base/java.lang.Thread.run(Thread.java:1583) ```
Configuration menu - View commit details
-
Copy full SHA for a7cd5dd - Browse repository at this point
Copy the full SHA a7cd5ddView commit details -
Use micronaut.server.ssl.port (#11507)
micronaut.ssl.port is deprecated
Configuration menu - View commit details
-
Copy full SHA for 3cf0bd3 - Browse repository at this point
Copy the full SHA 3cf0bd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15b6194 - Browse repository at this point
Copy the full SHA 15b6194View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a55d88 - Browse repository at this point
Copy the full SHA 2a55d88View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v4.7.11...v4.7.12