Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing @Nullable in bridge for brave Baggage implementation #883

Open
rgarciapariente opened this issue Nov 7, 2024 · 1 comment
Open
Labels
bug A general bug
Milestone

Comments

@rgarciapariente
Copy link

rgarciapariente commented Nov 7, 2024

Hello,

With version micrometer-tracing-bridge-brave:1.2.x you could do baggage.makeCurrent(null) to remove a baggage value but with micrometer-tracing-bridge-brave:1.3.x, all API are @NotNull by default.

Maybe, it is possible to add @Nullable to makeCurrent and set methods in class io.micrometer.tracing.brave.bridge.BraveBaggageInScope to avoid issues with nullabilities check?

Many thanks & regards

@shakuzen shakuzen changed the title Missing @Nullable in bridge for brave Baggage implementation Missing @Nullable in bridge for brave Baggage implementation Nov 7, 2024
@shakuzen shakuzen added bug A general bug and removed waiting-for-triage labels Nov 7, 2024
@shakuzen shakuzen added this to the 1.3.6 milestone Nov 7, 2024
@shakuzen
Copy link
Member

shakuzen commented Nov 7, 2024

Thanks for the report. It looks like that was done in #545. Probably we should have been more careful to note which API should accept nullable values.

@shakuzen shakuzen modified the milestones: 1.3.6, 1.3.x Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants