Add ObservationApplier abstraction #4850
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is trying to address the problem described in gh-4827.
ObservationApplier
andObservationApplierRegistry
abstractionsObservationApplier
forCompletionStage
ObservationApplier
that can be used on suspending methodsCons:
ObservationToSuspendingMethodApplier
will only work correctly when Spring Framework is in use (due the implementation taking advantage of how Spring AOP is handling calls to suspending functions)ObservationToSuspendingMethodApplier
needs to refer toMono
, and soio.projectreactor:reactor-core
is needed on the classpathObservationToSuspendingMethodApplier
is not registered automatically (could be done at the service startup by Spring Boot etc.)Not done yet:
Open Questions:
ObservationToSuspendingMethodApplier
potentially be moved to Spring Framework or Spring Boot instead?