Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump io.micrometer:context-propagation to 1.1.0 #4244

Closed
jonatan-ivanov opened this issue Oct 13, 2023 · 2 comments
Closed

Bump io.micrometer:context-propagation to 1.1.0 #4244

jonatan-ivanov opened this issue Oct 13, 2023 · 2 comments
Labels
dependency-upgrade A dependency upgrade
Milestone

Comments

@jonatan-ivanov
Copy link
Member

jonatan-ivanov commented Oct 13, 2023

See: bae5e10, 3513df3

@jonatan-ivanov jonatan-ivanov added the dependency-upgrade A dependency upgrade label Oct 13, 2023
@jonatan-ivanov jonatan-ivanov added this to the 1.12.0 milestone Oct 13, 2023
@izeye
Copy link
Contributor

izeye commented Oct 29, 2023

I'm curious if there's any policy change as since #4027, context-propagation doesn't seem to have made any functional changes, either.

@jonatan-ivanov
Copy link
Member Author

That's a great question. The short answer is: no policy change, this will be an exception though since we were asked by the Reactor team to release 1.1.

The longer answer: Reactor has a policy to support every patch version in a minor they depend on. E.g.: they depend on the latest context-propagation 1.0.x so they want to support it all the way back to 1.0.0. Unfortunately, certain bug fixes in context-propagation 1.0.x were public API changes (adding new methods). Reactor uses these new methods but since they are not available in earlier versions (like 1.0.0), Reactor needs to do some checks (/"hacks") to prevent NoSuchMethodException. They asked us to release 1.1.0 which has these methods so in their new minor release they can upgrade to 1.1.x and remove these checks. If we would not release 1.1.0, their next minor version would still use 1.0.x so they ned to support all the way back to 1.0.0 and keep the checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-upgrade A dependency upgrade
Projects
None yet
Development

No branches or pull requests

2 participants