Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service descriptor files not merged/transformed in statsd shadowJar #3268

Closed
shakuzen opened this issue Jul 6, 2022 · 0 comments
Closed
Assignees
Labels
bug A general bug registry: statsd A StatsD Registry related issue
Milestone

Comments

@shakuzen
Copy link
Member

shakuzen commented Jul 6, 2022

https://imperceptiblethoughts.com/shadow/configuration/merging/#merging-service-descriptor-files

The file name should be the shaded package name, and the contents of the file should be merged from all shaded dependencies that have the corresponding service descriptor file. In theory, I think the mergeServiceFiles() configuration mentioned in the documentation above should be enough to achieve this. In practice, it doesn't look like it is appending the service implementations in the produced file, but it is at least using the relocated shaded package for the one implementation it does include.

@shakuzen shakuzen added bug A general bug registry: statsd A StatsD Registry related issue labels Jul 6, 2022
@shakuzen shakuzen added this to the 1.8.x milestone Jul 6, 2022
@shakuzen shakuzen added the help wanted An issue that a contributor can help us with label Jul 6, 2022
@shakuzen shakuzen self-assigned this Jul 6, 2022
@shakuzen shakuzen modified the milestones: 1.8.x, 1.8.8 Jul 6, 2022
@shakuzen shakuzen removed the help wanted An issue that a contributor can help us with label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A general bug registry: statsd A StatsD Registry related issue
Projects
None yet
Development

No branches or pull requests

1 participant