Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Timed on @JMSListener should register timing metrics #302

Closed
nickstolwijk opened this issue Dec 15, 2017 · 3 comments
Closed

@Timed on @JMSListener should register timing metrics #302

nickstolwijk opened this issue Dec 15, 2017 · 3 comments
Labels
spring-boot change Change is needed in Spring Boot for this issue

Comments

@nickstolwijk
Copy link

Using Spring JMS and Spring Boot 2 I want to be able to put the @timed annotation on the methods with @JMSListener, so I can track how much messages I have processed and how long they took. (See the functionality for @scheduled)

@jkschneider jkschneider added this to the 1.1.0 milestone Feb 14, 2018
@jkschneider jkschneider added the spring-boot change Change is needed in Spring Boot for this issue label Oct 12, 2018
@jkschneider
Copy link
Contributor

Dependent on https://jira.spring.io/browse/SPR-14683

@klr8
Copy link

klr8 commented Jan 15, 2020

@nickstolwijk,
What exactly is preventing you from putting the @Timed annotation on an @JmsListener annotated method? For me this seems to work fine in Spring Boot 2.1.9:

@JmsListener(destination = "myqueue")
@Timed(value = "message.process", extraTags = {"queue", "myqueue"})
public void processMsg(String messageText, Message message) {

And

@Configuration
@EnableAspectJAutoProxy
public class AutoTimingConfiguration {
  @Bean
  public TimedAspect timedAspect(MeterRegistry registry) {
    return new TimedAspect(registry);
  }
}

@marcingrzejszczak
Copy link
Contributor

There was no feedback since 2020. We’ll close it for now, and if there still will be any interest, please comment on this issue and we’ll consider re-opening it.

@marcingrzejszczak marcingrzejszczak closed this as not planned Won't fix, can't repro, duplicate, stale Dec 21, 2023
@jonatan-ivanov jonatan-ivanov removed this from the 1.x milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spring-boot change Change is needed in Spring Boot for this issue
Projects
None yet
Development

No branches or pull requests

5 participants