Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory pressure binder #1911

Closed
jkschneider opened this issue Mar 17, 2020 · 2 comments
Closed

Memory pressure binder #1911

jkschneider opened this issue Mar 17, 2020 · 2 comments
Labels
enhancement A general enhancement
Milestone

Comments

@jkschneider
Copy link
Contributor

The meter binder provides methods to access measurements of low pool memory and heavy GC overhead as described in TeamCity's Memory Monitor.

It determines the percent of time spent in GC by computing a moving sum of the times of individual GC events (excluding concurrent phase GC events) divided by the moving interval. Sums are retained in a ring buffer whose elements expire at this predetermined interval.

To determine the accuracy of this method of determining GC overhead, the results emitted from the monitor were compared against JProfiler's notion of percent time spent in GC, and they were converged on roughly the same value, as seen below:

image

@jkschneider jkschneider modified the milestones: 1.1.12, 1.4.0 Mar 17, 2020
@checketts
Copy link
Contributor

Very cool! Thanks for this addition!

@shakuzen shakuzen added the enhancement A general enhancement label Mar 18, 2020
@shakuzen
Copy link
Member

I've polished in 5f4b201 renaming the one metric to jvm.memory.usage.after.gc to more closely align with the existing JVM memory metric names. Also that it is heap memory is already expressed via the tag on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants