Skip to content

Commit 7e35196

Browse files
Merge branch '1.13.x' into 1.14.x
2 parents 1c891c7 + 819fa61 commit 7e35196

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed

micrometer-jakarta9/src/main/java/io/micrometer/jakarta9/instrument/jms/JmsProcessObservationContext.java

+6-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616

1717
package io.micrometer.jakarta9.instrument.jms;
1818

19+
import io.micrometer.common.util.internal.logging.WarnThenDebugLogger;
1920
import io.micrometer.observation.transport.ReceiverContext;
20-
import jakarta.jms.JMSException;
2121
import jakarta.jms.Message;
2222

2323
/**
@@ -33,12 +33,16 @@
3333
*/
3434
public class JmsProcessObservationContext extends ReceiverContext<Message> {
3535

36+
private static final WarnThenDebugLogger logger = new WarnThenDebugLogger(JmsProcessObservationContext.class);
37+
3638
public JmsProcessObservationContext(Message receivedMessage) {
3739
super((message, key) -> {
3840
try {
3941
return message.getStringProperty(key);
4042
}
41-
catch (JMSException exc) {
43+
// Some JMS providers throw exceptions other than JMSException
44+
catch (Exception exc) {
45+
logger.log("Failed to get message property.", exc);
4246
return null;
4347
}
4448
});

micrometer-jakarta9/src/main/java/io/micrometer/jakarta9/instrument/jms/JmsPublishObservationContext.java

+9-6
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
package io.micrometer.jakarta9.instrument.jms;
1818

1919
import io.micrometer.common.lang.Nullable;
20+
import io.micrometer.common.util.internal.logging.WarnThenDebugLogger;
2021
import io.micrometer.observation.transport.SenderContext;
21-
import jakarta.jms.JMSException;
2222
import jakarta.jms.Message;
2323

2424
/**
@@ -33,15 +33,18 @@
3333
*/
3434
public class JmsPublishObservationContext extends SenderContext<Message> {
3535

36+
private static final WarnThenDebugLogger logger = new WarnThenDebugLogger(JmsPublishObservationContext.class);
37+
3638
public JmsPublishObservationContext(@Nullable Message sendMessage) {
3739
super((message, key, value) -> {
38-
try {
39-
if (message != null) {
40+
if (message != null) {
41+
try {
4042
message.setStringProperty(key, value);
4143
}
42-
}
43-
catch (JMSException exc) {
44-
// ignore
44+
// Some JMS providers throw exceptions other than JMSException
45+
catch (Exception exc) {
46+
logger.log("Failed to set message property.", exc);
47+
}
4548
}
4649
});
4750
setCarrier(sendMessage);

0 commit comments

Comments
 (0)