Fix for reset/panic overriding the user's stop #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to an enum to make the possible states easier to follow and so we can check we're in the default state before committing to a reset or panic. Closes #86
✅ Deploy Preview for distracted-dubinsky-fd8a42 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I don't think it was consequential as it's called only from the message handler which doesn't need to wait for the result.
microbit-matt-hillsdon
changed the title
|
As this affects key functionality, I'll stand-up a branch of the V3 editor that uses the review branch from this PR so we can test the start/stop/reset functionality in that context. |
|
URL to embed: https://review-python-simulator.usermbit.org/user-stop-wins/simulator.html V3 editor review branch using the above: https://review-python-editor-v3.microbit.org/user-stop-wins/ |
Reset/Panic are only applicable internally.
microbit-robert
approved these changes
Oct 31, 2022
Co-authored-by: Robert Knight <95928279+microbit-robert@users.noreply.github.com>
microbit-matt-hillsdon
added a commit
that referenced
this pull request
Nov 1, 2022
This reverts commit 7c5b2e6.
microbit-matt-hillsdon
added a commit
that referenced
this pull request
Nov 2, 2022
This reverts commit 9d7c834.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to an enum to make the possible states easier to follow and so we can check we're in the default state before committing to a reset or panic.
Closes #86