Resample via a libsamplerate #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to do this for recording as we can't specify a rate. We need to do this for playback for sample rates outside of the browser's supported range. That includes the current default rate for Firefox and older Safari. Uses a resampler build that doesn't support medium/best to save on bundle size. I've also increased the buffer size so I can play a 44k sample in an OK-ish way. Maybe 256 will be needed. We know Firefox on Windows still performs poorly. It did badly with audio before these changes.
|
Preview build will be at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to do this for recording as we can't specify a rate.
We need to do this for playback for sample rates outside of the browser's supported range. That includes the current default rate for Firefox and older Safari.
Uses a resampler build that doesn't support medium/best to save on bundle size.
I've also increased the buffer size so I can play a 44k sample in an OK-ish way. Maybe 256 will be needed.
We know Firefox on Windows still performs poorly. It did badly with audio before these changes.
Another significant issue is that it can take 3 seconds to call getUserMedia on Desktop Safari.