Skip to content

Add error logging for bluetooth connection failure #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

microbit-robert
Copy link
Contributor

@microbit-robert microbit-robert commented Dec 4, 2024

Unfortunately, we recieved the model number error when the connect promise resolves, which can be before or after this catch block runs. I'm not sure there is a way around this, as the connect promise can hang around indefinitely for macOS.

@microbit-robert microbit-robert requested a review from a team December 4, 2024 14:41
Copy link
Contributor

@microbit-grace microbit-grace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested out the error logging when unplugging the micro:bit mid connecting. I can see the logged errors, LGTM.

Screenshot 2024-12-04 at 14 57 14

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 86cbb6a into main Dec 4, 2024
2 checks passed
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the error-logging branch December 4, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants