Remove connect options in favour of setters #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to create a radio bridge connection instance upfront.
microbit-robert
commented
Jul 23, 2024
| @@ -121,7 +118,7 @@ const createConnectSection = (type: ConnectionType): Section => { | |||
| "button", | |||
| { | |||
| onclick: () => { | |||
| void connection.connect({ name: name || undefined }); | |||
| void connection.connect(); | |||
There was a problem hiding this comment.
We'll need to come back to this and set the name filter for the Bluetooth connection if a name has been provided.
microbit-robert
commented
Jul 24, 2024
src/demo.ts
Outdated
Comment on lines
58
to
60
| if (connection instanceof MicrobitRadioBridgeConnection) { | ||
| connection.setRemoteDeviceId(0); | ||
| } |
There was a problem hiding this comment.
Making the demo a bit worse again.
There was a problem hiding this comment.
We may as well do this at the point we create the connection when we know its type.
|
As discussed in person this API should probably change but let's get our internal clients using it and evolve it with usage in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to create a radio bridge connection instance upfront.