fix(yaml parser): safer multi-document yaml split

Pajk · Pajk · commit ec9d6811e7be · 2019-03-04T22:24:55.000+01:00
diff --git a/lib/parsed-yaml-retriever.js b/lib/parsed-yaml-retriever.js
@@ -12,7 +12,7 @@ const getParsedYaml = gh => async data => {
     const file = await promisify(gh.repos.getContent)(options)
     contents = Buffer.from(file.content, 'base64').toString()
   }
-  const docs = contents.split('---')
+  const docs = contents.split('\n---\n')
   const parsedDocs = docs.map(d => {
     return yaml.parse(d)
   })

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ const getParsedYaml = gh => async data => {`
`12`	`12`	`const file = await promisify(gh.repos.getContent)(options)`
`13`	`13`	`contents = Buffer.from(file.content, 'base64').toString()`
`14`	`14`	`}`
`15`		`- const docs = contents.split('---')`
	`15`	`+ const docs = contents.split('\n---\n')`
`16`	`16`	`const parsedDocs = docs.map(d => {`
`17`	`17`	`return yaml.parse(d)`
`18`	`18`	`})`