-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5 event package #2728
Comments
I think the two interfaces had a lot of overlapping concerns. So we could add some of that to the broker. Can you detail what parts you'd like to include? |
I agree with you, but the two interfaces had different purposes. Broker = pub/sub, event = event streaming with multiple policies. From message the Ack,Nack functions. And the most important think is to handle topic filtering, with the broker is not possible. |
What's your ideal solution? Reintroduce the event interface? |
If you need it. You can make a PR to bring it back. |
Broker can do all the things, auto ack is simple if defer func() { |
We will bring a solution in PR
It is not a good solution in some situation.
I do not know nothing about kafka, but a lot of event broker use a * and similar character for filtering in a topic name. But rpc_server and the router try to find subscriber with the topic name he got from the broker, which is the full topic name, not the filtered. eg.: But we will bring a solution for this "problem" too, in PR. |
ah =) in my fork i'm remove ability to subscribe via server package and use broker directly, with ability to unmarshal to needed struct pointer |
The event package has been deleted in v5 branch.
Is there any plan to do this?
How can we replace the event handling?
Brokers have much less functionality, and in theory no guarantee of delivery.
The text was updated successfully, but these errors were encountered: