Merge pull request #131 from micro-toolkit/fix/130-embeds-without-nil-values

embeds shouldnt send nil values to batch operation

Author: pjanuario

lib/embed.js

@@ -37,7 +37,7 @@ function fetchEmbed(relations, config, data, headers){
     var toModel = model(config, metadata);
     var payloadKey = isResource ? parent.idKey : relation.modelFk;
     var payload = {};
-    payload[payloadKey] = _.map(data, idKey);
+    payload[payloadKey] = _.reject(_.map(data, idKey), _.isNil);
 
     log.debug('Embeds subresource %s in request', relation.name);
     return client.batch(payload, headers)

tests/embeds_test.js

@@ -144,6 +144,16 @@ describe('Unit | embeds', function() {
       .should.eventually.have.deep.property('0.user');
   });
 
+  it('should embed resource in a collection without null values', function() {
+    sinon.stub(serviceStub, 'batch')
+      .withArgs({id: ['u1']})
+      .resolves({payload: [{id: 'u1', data: userData}] });
+
+    var tasks = [taskData, { id: 't2', userId: null }];
+    return target(metadata.v1.task, config, {query:{embeds: 'user'}}, tasks)
+      .should.eventually.have.deep.property('1.user', null);
+  });
+
   it('should embed resource in a resource', function() {
     sinon.stub(serviceStub, 'batch')
       .withArgs({id: ['u1']})