Pass index and original array in .filter #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesla
reviewed
Nov 28, 2016
| @@ -125,6 +125,13 @@ test('filter()', t => { | |||
| t.deepEqual(actual, expected); | |||
| }); | |||
|
|
|||
| test('filter() unique values', t => { | |||
There was a problem hiding this comment.
this describes a use case for using the index and originalArray properties, but not the actual functionality.
I think the test would be better (more descriptive) if the title at least was more generic. Might also make sense to create a simpler test.
Another idea would be to add a .unique method to immutable-array-methods!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review: @kesla
Type: Minor
Adds index and original array to callback parameters in
.filter(), to be compatible with standard jsarray.filter.