#153 XSS safty improvements

micmro · Mar 26, 2017 · 0a98ffb · 0a98ffb
1 parent 1d8f487
commit 0a98ffb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/ts/transformers/har-tabs.ts b/src/ts/transformers/har-tabs.ts
@@ -131,5 +131,5 @@ function makeImgTab(entry: Entry): WaterfallEntryTab {
   return makeLazyWaterfallEntryTab(
     "Preview",
     (detailsHeight: number) => `<img class="preview" style="max-height:${(detailsHeight - 100)}px"
- data-src="${entry.request.url}" />`);
+ data-src="${entry.request.url.replace("\"", "&quot;")}" />`);
 }
diff --git a/src/ts/transformers/helpers.ts b/src/ts/transformers/helpers.ts
@@ -25,7 +25,7 @@ export function makeDefinitionList(dlKeyValues: KvTuple[], addClass: boolean = f
   return dlKeyValues
     .filter((tuple: KvTuple) => tuple[1] !== undefined)
     .map((tuple) => `
-      <dt ${makeClass(tuple[0])}>${tuple[0]}</dt>
+      <dt ${makeClass(tuple[0])}>${escapeHtml(tuple[0])}</dt>
       <dd>${escapeHtml(tuple[1])}</dd>
     `).join("");
 }