Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using a Session object for HTTP requests #16

Open
johnwmillr opened this issue Aug 20, 2018 · 0 comments
Open

Switch to using a Session object for HTTP requests #16

johnwmillr opened this issue Aug 20, 2018 · 0 comments

Comments

@johnwmillr
Copy link
Collaborator

Copied from issue on tejassharma96's repository.


I propose switching to a Session object from the requests library for the package's HTTP requests. We're currently opening a new connection to the same host for each request. Making this switch would allow some parameters to persist between a users's requests, which may be friendlier to the Pitchfork server.

I'd be able to handle the switch over to the requests library, but I'll try to think some more first on whether it really makes sense to make the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant