From 4537fc55ac4791f2d5f74725c91397a2a8c1d36b Mon Sep 17 00:00:00 2001 From: antoniocortes Date: Thu, 20 Sep 2018 08:37:41 -0700 Subject: [PATCH] A couple of improvements to JRE test makefiles. - Add dependency test_sources.mk to target AllJreTests.java. - Remove unused constant FAILING_TESTS Change on 2018/09/20 by antoniocortes ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=213819383 --- jre_emul/test_sources.mk | 3 --- jre_emul/tests.mk | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/jre_emul/test_sources.mk b/jre_emul/test_sources.mk index 194cbe66c9..85c5e61d97 100644 --- a/jre_emul/test_sources.mk +++ b/jre_emul/test_sources.mk @@ -841,9 +841,6 @@ TESTS_TO_SKIP = \ org/apache/harmony/tests/javax/net/ssl/SSLSocketFactoryTest.java \ org/apache/harmony/tests/javax/net/ssl/SSLSocketTest.java -FAILING_TESTS = \ - libcore/java/text/DateFormatSymbolsTest.java - # Most of these tests are failing for a common index-out-of-range error. FAILING_MATH_TESTS = \ org/apache/harmony/tests/java/math/BigDecimalArithmeticTest.java \ diff --git a/jre_emul/tests.mk b/jre_emul/tests.mk index b095b47b3d..38f52d0024 100644 --- a/jre_emul/tests.mk +++ b/jre_emul/tests.mk @@ -255,7 +255,7 @@ $(TEST_BIN): $(TEST_OBJS) $(SUPPORT_LIB) $(DIST_JRE_EMUL_LIB) $(DIST_JUNIT_LIB) @echo " " $(TEST_JOCC) $(LINK_FLAGS) ... @$(TEST_JOCC) $(LINK_FLAGS) -o $@ $(TEST_OBJS) -$(ALL_TESTS_SOURCE): tests.mk +$(ALL_TESTS_SOURCE): tests.mk test_sources.mk @mkdir -p $(@D) @xcrun awk -f gen_all_tests.sh $(TESTS_TO_RUN) > $@