Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Don't reassign reducer parameter when there are no conditions #8

Open
michaelboyles opened this issue Nov 1, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@michaelboyles
Copy link
Owner

As a consequence of the code which handles code paths (if conditions etc.), Redcr always ends up reassigning the parameter, regardless of whether it actually needs to. For example

interface StringState {
    str: String
}
const reducer = redcr((state: StringState) => {
    state.str = 'foo';
});

The generated code looks like this

const reducer = (state) => {
    state = {
        ...state,
        str: 'foo'
    };
    return state;
};

It would be better if it returned this

const reducer = (state) => {
    return {
        ...state,
        str: 'foo'
    };
};
@michaelboyles michaelboyles added the enhancement New feature or request label Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant