Skip to content

Commit aa1a95d

Browse files
yongtangmichaelbanfield
authored andcommitted
Remove the CI build for CentOS 8 (tensorflow#1237)
Building shared libraries on CentOS 8 is pretty much the same as on Ubuntu 20.04 except `apt` should be changed to `yum`. For that our CentOS 8 CI test is not adding a lot of value. Furthermore with the upcoming CentOS 8 change: https://www.phoronix.com/scan.php?page=news_item&px=CentOS-8-Ending-For-Stream CentOS 8 is effectively EOLed at 2021. For that we may want to drop the CentOS 8 build (only leave a comment in README.md) Note we keep CentOS 7 build for now as there are still many users using CentOS 7 and CentOS 7 will only be EOLed at 2024. We might drop CentOS 7 build in the future as well if there is similiar changes to CentOS 7 like CentOS 8. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
1 parent 04d6913 commit aa1a95d

File tree

2 files changed

+4
-38
lines changed

2 files changed

+4
-38
lines changed

.github/workflows/build.yml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -72,19 +72,6 @@ jobs:
7272
docker run -i --rm -v $PWD:/v -w /v --net=host ubuntu:20.04 \
7373
bash -x -e source.sh
7474
75-
centos-8:
76-
name: CentOS 8
77-
runs-on: ubuntu-latest
78-
steps:
79-
- uses: actions/checkout@v2
80-
- run: |
81-
set -x -e
82-
bash -x -e .github/workflows/build.space.sh
83-
python3 .github/workflows/build.instruction.py README.md "##### CentOS 8" > source.sh
84-
cat source.sh
85-
docker run -i --rm -v $PWD:/v -w /v --net=host centos:8 \
86-
bash -x -e source.sh
87-
8875
centos-7:
8976
name: CentOS 7
9077
runs-on: ubuntu-latest

README.md

Lines changed: 4 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -277,33 +277,12 @@ TFIO_DATAPATH=bazel-bin python3 -m pytest -s -v tests/test_serialization_eager.p
277277

278278
##### CentOS 8
279279

280-
CentOS 8 requires gcc/g++, git, and python 3. The following will install dependencies and build
281-
the shared libraries on CentOS 8:
282-
```sh
283-
#!/usr/bin/env bash
284-
285-
# Install gcc/g++, git, unzip/which (for bazel), and python3
280+
The steps to build shared libraries for CentOS 8 is similiar to Ubuntu 20.04 above
281+
excpet that
282+
```
286283
sudo yum install -y python3 python3-devel gcc gcc-c++ git unzip which make
287-
288-
# Install Bazel version specified in .bazelversion
289-
curl -sSOL https://github.com/bazelbuild/bazel/releases/download/$(cat .bazelversion)/bazel-$(cat .bazelversion)-installer-linux-x86_64.sh
290-
sudo bash -x -e bazel-$(cat .bazelversion)-installer-linux-x86_64.sh
291-
292-
# Upgrade pip
293-
sudo python3 -m pip install -U pip
294-
295-
# Install tensorflow and configure bazel
296-
sudo ./configure.sh
297-
298-
# Build shared libraries
299-
bazel build -s --verbose_failures //tensorflow_io/...
300-
301-
# Once build is complete, shared libraries will be available in
302-
# `bazel-bin/tensorflow_io/core/python/ops/` and it is possible
303-
# to run tests with `pytest`, e.g.:
304-
sudo python3 -m pip install pytest
305-
TFIO_DATAPATH=bazel-bin python3 -m pytest -s -v tests/test_serialization_eager.py
306284
```
285+
should be used instead to install gcc/g++, git, unzip/which (for bazel), and python3.
307286

308287
##### CentOS 7
309288

0 commit comments

Comments
 (0)