From 8d17527050cd9700d6ea18b43a337c29a07a7eb9 Mon Sep 17 00:00:00 2001
From: Zachary Tong <zach@elastic.co>
Date: Mon, 9 Sep 2019 10:01:36 -0400
Subject: [PATCH] [TEST] create larger cuckoo filters for tests (#46457)

The cuckoofilters could be randomly created with too small of
capacity or precision, which means that they can only absorb a few
values before collisions start to make all filters look identical.

This increases the size of filters we generate (capacity >> than
the test cases) and lower fpp rate.
---
 .../common/util/CuckooFilterTests.java              | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/server/src/test/java/org/elasticsearch/common/util/CuckooFilterTests.java b/server/src/test/java/org/elasticsearch/common/util/CuckooFilterTests.java
index 47e9081d815b6..61d2dd62c9aad 100644
--- a/server/src/test/java/org/elasticsearch/common/util/CuckooFilterTests.java
+++ b/server/src/test/java/org/elasticsearch/common/util/CuckooFilterTests.java
@@ -30,8 +30,8 @@ public class CuckooFilterTests extends AbstractWireSerializingTestCase<CuckooFil
 
     @Override
     protected CuckooFilter createTestInstance() {
-        CuckooFilter filter = new CuckooFilter(randomIntBetween(1, 100000),
-            ((float)randomIntBetween(1, 50)) / 100.0, Randomness.get());
+        CuckooFilter filter = new CuckooFilter(randomIntBetween(10000, 100000),
+            ((float)randomIntBetween(1, 20)) / 100.0, Randomness.get());
 
         int num = randomIntBetween(0, 10);
         for (int i = 0; i < num; i++) {
@@ -53,6 +53,15 @@ protected CuckooFilter mutateInstance(CuckooFilter instance) {
         for (int i = 0; i < num; i++) {
             newInstance.add(hash(randomLong()));
         }
+        int attempts = 0;
+        while (newInstance.getCount() == instance.getCount() && attempts < 100) {
+            newInstance.add(hash(randomLong()));
+            attempts += 1;
+        }
+        if (newInstance.equals(instance)) {
+            fail("Unable to mutate filter enough to generate a different version. " +
+                "Are capacity/precision defaults too low?");
+        }
         return newInstance;
     }