Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require GraphViz GUI app on MacOS #133

Open
reynoldsnlp opened this issue Oct 14, 2021 · 2 comments
Open

Don't require GraphViz GUI app on MacOS #133

reynoldsnlp opened this issue Oct 14, 2021 · 2 comments

Comments

@reynoldsnlp
Copy link

$ foma -v
foma 0.10.0alpha

I have graphviz installed (via MacPorts) on my machine:

$ type dot
dot is hashed (/opt/local/bin/dot)

However, after adding rules in the REPL, when I type view net I get the following:

foma[1]: view net
foma[1]: Unable to find application named 'Graphviz'

The code requires the GUI app, rather than the command line utilities: https://github.com/mhulden/foma/blob/master/foma/iface.c#L1704. This seems unnecessary.

The code should call dot or other algorithms directly. The MacPorts graphviz package is a dependency of graphviz-gui so the command line utilities would be present in either case.

@reynoldsnlp
Copy link
Author

Really, Mac should be exactly the same as Linux except that it would use open instead of xdg-open.

@simon-clematide
Copy link

I fully agree and provided a pull request #81 with same suggestion. MacOS users of foma should be able to install graphviz via macports or brew. I don't think that GraphViz will be back soonish as a simple installable package under MacOS (if I understand correctly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants