getLiteralTypeFromPropertyName hides private names

Signed-off-by: Max Heiber <max.heiber@gmail.com>

Author: mheiber

src/compiler/checker.ts

@@ -9044,7 +9044,9 @@ namespace ts {
         }
 
         function getLiteralTypeFromPropertyName(prop: Symbol, include: TypeFlags) {
-            if (!(getDeclarationModifierFlagsFromSymbol(prop) & ModifierFlags.NonPublicAccessibilityModifier)) {
+            const hasNonPublicModifier = !!(getDeclarationModifierFlagsFromSymbol(prop) & ModifierFlags.NonPublicAccessibilityModifier);
+            const hasPrivateName = prop.valueDeclaration && isNamedDeclaration(prop.valueDeclaration) && isPrivateName(prop.valueDeclaration.name);
+            if (!hasNonPublicModifier && !hasPrivateName) {
                 let type = getLateBoundSymbol(prop).nameType;
                 if (!type && !isKnownSymbol(prop)) {
                     const name = prop.valueDeclaration && getNameOfDeclaration(prop.valueDeclaration);

tests/baselines/reference/privateNamesAndkeyof.js

@@ -0,0 +1,16 @@
+//// [privateNamesAndkeyof.ts]
+class A {
+    #foo;
+    bar;
+    baz;
+}
+
+type T = keyof A     // should not include '#foo'
+
+
+//// [privateNamesAndkeyof.js]
+var A = /** @class */ (function () {
+    function A() {
+    }
+    return A;
+}());

tests/baselines/reference/privateNamesAndkeyof.symbols

@@ -0,0 +1,18 @@
+=== tests/cases/conformance/classes/members/privateNames/privateNamesAndkeyof.ts ===
+class A {
+>A : Symbol(A, Decl(privateNamesAndkeyof.ts, 0, 0))
+
+    #foo;
+>#foo : Symbol(A[#foo], Decl(privateNamesAndkeyof.ts, 0, 9))
+
+    bar;
+>bar : Symbol(A.bar, Decl(privateNamesAndkeyof.ts, 1, 9))
+
+    baz;
+>baz : Symbol(A.baz, Decl(privateNamesAndkeyof.ts, 2, 8))
+}
+
+type T = keyof A     // should not include '#foo'
+>T : Symbol(T, Decl(privateNamesAndkeyof.ts, 4, 1))
+>A : Symbol(A, Decl(privateNamesAndkeyof.ts, 0, 0))
+

tests/baselines/reference/privateNamesAndkeyof.types

@@ -0,0 +1,17 @@
+=== tests/cases/conformance/classes/members/privateNames/privateNamesAndkeyof.ts ===
+class A {
+>A : A
+
+    #foo;
+>#foo : any
+
+    bar;
+>bar : any
+
+    baz;
+>baz : any
+}
+
+type T = keyof A     // should not include '#foo'
+>T : "bar" | "baz"
+

tests/cases/conformance/classes/members/privateNames/privateNamesAndkeyof.ts

@@ -0,0 +1,7 @@
+class A {
+    #foo;
+    bar;
+    baz;
+}
+
+type T = keyof A     // should not include '#foo'